DPDK patches and discussions
 help / color / mirror / Atom feed
From: stephen@networkplumber.org
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 2/8] vmxnet3: remove mtu check
Date: Thu,  9 Jul 2015 11:24:10 -0700	[thread overview]
Message-ID: <1436466256-17442-3-git-send-email-stephen@networplumber.org> (raw)
In-Reply-To: <1436466256-17442-1-git-send-email-stephen@networplumber.org>

From: Stephen Hemminger <stephen@networkplumber.org>

Remove check for packets greater than MTU. No other driver does
this, it should be handled at higher layer

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Yong Wang <yongwang@vmware.com>
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c |  2 --
 drivers/net/vmxnet3/vmxnet3_ethdev.h |  1 -
 drivers/net/vmxnet3/vmxnet3_rxtx.c   | 10 ----------
 3 files changed, 13 deletions(-)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 3caa4c0..3bec173 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -216,7 +216,6 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)
 
 	hw->num_rx_queues = 1;
 	hw->num_tx_queues = 1;
-	hw->cur_mtu = ETHER_MTU;
 	hw->bufs_per_pkt = 1;
 
 	/* Check h/w version compatibility with driver. */
@@ -391,7 +390,6 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)
 
 	devRead->misc.queueDescPA  = hw->queueDescPA;
 	devRead->misc.queueDescLen = hw->queue_desc_len;
-	devRead->misc.mtu          = hw->cur_mtu;
 	devRead->misc.numTxQueues  = hw->num_tx_queues;
 	devRead->misc.numRxQueues  = hw->num_rx_queues;
 
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.h b/drivers/net/vmxnet3/vmxnet3_ethdev.h
index e97e3ca..b392061 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.h
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.h
@@ -107,7 +107,6 @@ struct vmxnet3_hw {
 	uint8_t num_tx_queues;
 	uint8_t num_rx_queues;
 	uint8_t bufs_per_pkt;
-	uint16_t cur_mtu;
 
 	Vmxnet3_TxQueueDesc   *tqd_start;	/* start address of all tx queue desc */
 	Vmxnet3_RxQueueDesc   *rqd_start;	/* start address of all rx queue desc */
diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index 14f6c1d..eb5d096 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
@@ -368,16 +368,6 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
 				continue;
 			}
 
-			/* Needs to minus ether header len */
-			if (txm->data_len > (hw->cur_mtu + ETHER_HDR_LEN)) {
-				PMD_TX_LOG(DEBUG, "Packet data_len higher than MTU");
-				rte_pktmbuf_free(tx_pkts[nb_tx]);
-				txq->stats.drop_total++;
-
-				nb_tx++;
-				continue;
-			}
-
 			txd = (Vmxnet3_TxDesc *)(txq->cmd_ring.base + txq->cmd_ring.next2fill);
 			if (rte_pktmbuf_pkt_len(txm) <= VMXNET3_HDR_COPY_SIZE) {
 				struct Vmxnet3_TxDataDesc *tdd;
-- 
2.1.4

  parent reply	other threads:[~2015-07-09 18:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 18:24 [dpdk-dev] [PATCH v3 0/8] vmxnet3: driver updates stephen
2015-07-09 18:24 ` [dpdk-dev] [PATCH 1/8] vmxnet3: enable VLAN filtering stephen
2015-07-09 18:24 ` stephen [this message]
2015-07-09 18:24 ` [dpdk-dev] [PATCH 3/8] vmxnet3: cleanup txq stats stephen
2015-07-09 18:24 ` [dpdk-dev] [PATCH 4/8] vmxnet3: add support for multi-segment transmit stephen
2015-07-09 18:24 ` [dpdk-dev] [PATCH 5/8] vmxnet3: fix link state handling stephen
2015-07-09 18:24 ` [dpdk-dev] [PATCH 6/8] vmxnet3: support RSS and refactor offload stephen
2015-07-09 18:24 ` [dpdk-dev] [PATCH 7/8] vmxnet3: get rid of DEBUG ifdefs stephen
2015-07-09 18:24 ` [dpdk-dev] [PATCH 8/8] vmxnet3: remove unnecessary inlining stephen
2015-07-09 18:46 ` [dpdk-dev] [PATCH v3 0/8] vmxnet3: driver updates Yong Wang
2015-07-09 22:32   ` Thomas Monjalon
     [not found]   ` <73f62d318c9a4db790b71f334fd9354b@HQ1WP-EXMB11.corp.brocade.com>
2015-07-09 23:04     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436466256-17442-3-git-send-email-stephen@networplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).