From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by dpdk.org (Postfix) with ESMTP id 2026F5A44 for ; Thu, 9 Jul 2015 20:24:10 +0200 (CEST) Received: by pacws9 with SMTP id ws9so155952743pac.0 for ; Thu, 09 Jul 2015 11:24:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6qk6datt1zgmcMLZQeaA8t91pHY+umwp8vR2OSudOpU=; b=L+inf9gBnJxfavj3mk1Qui2251kdSGS9yka0fXw0tkxXLrO8FJwFEgxvXKKS5sswld Wo6x1Flt5/+RsYyYxLpM8PFDFet7qxsjVigmK6pX68q5zZfV/iJ4qBjfk8sSZZz7CW6F 2UZxCDdDLRIEVhFcYBOnE2QJt4P6GKTegUQGSGtRedp0SHbXCKnLFDf8VFFzXJ9yHTHm FFZ/0B65eq9hmqDCSmsx1ZUb61Vg47bescWIl5ICmrhsyIXIui3a36kT5aaM8zZACIBD tc1k4O5FcryGQJzmUuTuVqorIj7qn5F1KuhOZ7JD16exg3cPQWTTeecAVGhaQke9/6LF RKcA== X-Gm-Message-State: ALoCoQmrQSA6CRJfEkUzgJpXmlK9C3pXmn4Rzk9Kkff/tUQGXR6JuxxA+k9G0yEv15xH57uUbJzM X-Received: by 10.70.96.194 with SMTP id du2mr34473625pdb.108.1436466249532; Thu, 09 Jul 2015 11:24:09 -0700 (PDT) Received: from urahara.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id ff10sm6741567pab.13.2015.07.09.11.24.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Jul 2015 11:24:08 -0700 (PDT) From: stephen@networkplumber.org X-Google-Original-From: stephen@networplumber.org To: dev@dpdk.org Date: Thu, 9 Jul 2015 11:24:10 -0700 Message-Id: <1436466256-17442-3-git-send-email-stephen@networplumber.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436466256-17442-1-git-send-email-stephen@networplumber.org> References: <1436466256-17442-1-git-send-email-stephen@networplumber.org> Subject: [dpdk-dev] [PATCH 2/8] vmxnet3: remove mtu check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 18:24:10 -0000 From: Stephen Hemminger Remove check for packets greater than MTU. No other driver does this, it should be handled at higher layer Signed-off-by: Stephen Hemminger Acked-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 -- drivers/net/vmxnet3/vmxnet3_ethdev.h | 1 - drivers/net/vmxnet3/vmxnet3_rxtx.c | 10 ---------- 3 files changed, 13 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index 3caa4c0..3bec173 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -216,7 +216,6 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev) hw->num_rx_queues = 1; hw->num_tx_queues = 1; - hw->cur_mtu = ETHER_MTU; hw->bufs_per_pkt = 1; /* Check h/w version compatibility with driver. */ @@ -391,7 +390,6 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev) devRead->misc.queueDescPA = hw->queueDescPA; devRead->misc.queueDescLen = hw->queue_desc_len; - devRead->misc.mtu = hw->cur_mtu; devRead->misc.numTxQueues = hw->num_tx_queues; devRead->misc.numRxQueues = hw->num_rx_queues; diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.h b/drivers/net/vmxnet3/vmxnet3_ethdev.h index e97e3ca..b392061 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.h +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.h @@ -107,7 +107,6 @@ struct vmxnet3_hw { uint8_t num_tx_queues; uint8_t num_rx_queues; uint8_t bufs_per_pkt; - uint16_t cur_mtu; Vmxnet3_TxQueueDesc *tqd_start; /* start address of all tx queue desc */ Vmxnet3_RxQueueDesc *rqd_start; /* start address of all rx queue desc */ diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index 14f6c1d..eb5d096 100644 --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c @@ -368,16 +368,6 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, continue; } - /* Needs to minus ether header len */ - if (txm->data_len > (hw->cur_mtu + ETHER_HDR_LEN)) { - PMD_TX_LOG(DEBUG, "Packet data_len higher than MTU"); - rte_pktmbuf_free(tx_pkts[nb_tx]); - txq->stats.drop_total++; - - nb_tx++; - continue; - } - txd = (Vmxnet3_TxDesc *)(txq->cmd_ring.base + txq->cmd_ring.next2fill); if (rte_pktmbuf_pkt_len(txm) <= VMXNET3_HDR_COPY_SIZE) { struct Vmxnet3_TxDataDesc *tdd; -- 2.1.4