From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id E9B7BC336 for ; Thu, 9 Jul 2015 20:24:15 +0200 (CEST) Received: by pdjr16 with SMTP id r16so8192476pdj.3 for ; Thu, 09 Jul 2015 11:24:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gy4cqlAUstXfP8BK7UXkfQdfcDK2yReJFsFnUymtuZc=; b=GXoBx4YgfCQ/dgFLmlIQaPmeKBayH0DIj32+id5B1FgLCNZx99eq5nsS5+n6ttoHzc STouOaywTUv2eIYRIFx27IdSGFlEkPZnbDrnxu6VzevqECoDWsILAAXg0A5ttheKzgiq RP0iRJtg+ikYl7xnXqthDYL+walaKsSLSj0f0zJUWU7ZhwuFZku+K9PymR8w1AJYCbTA Q9BZhC1fpgg/cnsMR6UCtOZhNzQ4zNWxgWpVzZtfLrUGqOFOdl9Qk/SmtZsA9Ge8egPp I14iNcJHy04zz4NhrHDryON6iY2fLTGBu7zp5FUS5l19gbBD+xW6MZzDjSfc95z/oADh 5Tmw== X-Gm-Message-State: ALoCoQnKdWMcPHtNalhnkrAQOqfDkK5NQeguoaBArEQ8XSvIrZH1+UuJhOCSqpuVIMQfTr4Ru9dc X-Received: by 10.66.66.202 with SMTP id h10mr33584298pat.145.1436466255354; Thu, 09 Jul 2015 11:24:15 -0700 (PDT) Received: from urahara.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id ff10sm6741567pab.13.2015.07.09.11.24.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Jul 2015 11:24:14 -0700 (PDT) From: stephen@networkplumber.org X-Google-Original-From: stephen@networplumber.org To: dev@dpdk.org Date: Thu, 9 Jul 2015 11:24:16 -0700 Message-Id: <1436466256-17442-9-git-send-email-stephen@networplumber.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436466256-17442-1-git-send-email-stephen@networplumber.org> References: <1436466256-17442-1-git-send-email-stephen@networplumber.org> Cc: Stephen Hemminger Subject: [dpdk-dev] [PATCH 8/8] vmxnet3: remove unnecessary inlining X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 18:24:16 -0000 From: Stephen Hemminger No reason to inline large functions. Compiler will decide already based on optimization level. Also register array should be const. Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index c680346..e2f4b78 100644 --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c @@ -83,16 +83,16 @@ #define RTE_MBUF_DATA_DMA_ADDR_DEFAULT(mb) \ (uint64_t) ((mb)->buf_physaddr + RTE_PKTMBUF_HEADROOM) -static uint32_t rxprod_reg[2] = {VMXNET3_REG_RXPROD, VMXNET3_REG_RXPROD2}; +static const uint32_t rxprod_reg[2] = {VMXNET3_REG_RXPROD, VMXNET3_REG_RXPROD2}; -static inline int vmxnet3_post_rx_bufs(vmxnet3_rx_queue_t* , uint8_t); -static inline void vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *); +static int vmxnet3_post_rx_bufs(vmxnet3_rx_queue_t* , uint8_t); +static void vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *); #ifdef RTE_LIBRTE_VMXNET3_DEBUG_DRIVER_NOT_USED static void vmxnet3_rxq_dump(struct vmxnet3_rx_queue *); static void vmxnet3_txq_dump(struct vmxnet3_tx_queue *); #endif -static inline struct rte_mbuf * +static struct rte_mbuf * rte_rxmbuf_alloc(struct rte_mempool *mp) { struct rte_mbuf *m; @@ -156,7 +156,7 @@ vmxnet3_txq_dump(struct vmxnet3_tx_queue *txq) } #endif -static inline void +static void vmxnet3_cmd_ring_release_mbufs(vmxnet3_cmd_ring_t *ring) { while (ring->next2comp != ring->next2fill) { @@ -295,7 +295,7 @@ vmxnet3_dev_clear_queues(struct rte_eth_dev *dev) } } -static inline void +static void vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *txq) { int completed = 0; @@ -432,7 +432,7 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, * only for LRO. * */ -static inline int +static int vmxnet3_post_rx_bufs(vmxnet3_rx_queue_t *rxq, uint8_t ring_id) { int err = 0; -- 2.1.4