DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <shemming@brocade.com>
Subject: [dpdk-dev] [PATCH v3 5/6] e1000: change log level of debug messages
Date: Thu,  9 Jul 2015 16:01:07 -0700	[thread overview]
Message-ID: <1436482868-7400-6-git-send-email-stephen@networkplumber.org> (raw)
In-Reply-To: <1436482868-7400-1-git-send-email-stephen@networkplumber.org>

From: Stephen Hemminger <shemming@brocade.com>

Any debug messages about hardware should be under debug (or removed)
and reduce customer visible log spam.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/e1000/em_ethdev.c  | 5 +++--
 drivers/net/e1000/igb_ethdev.c | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
index a306c55..29053a1 100644
--- a/drivers/net/e1000/em_ethdev.c
+++ b/drivers/net/e1000/em_ethdev.c
@@ -275,7 +275,7 @@ eth_em_dev_init(struct rte_eth_dev *eth_dev)
 	/* initialize the vfta */
 	memset(shadow_vfta, 0, sizeof(*shadow_vfta));
 
-	PMD_INIT_LOG(INFO, "port_id %d vendorID=0x%x deviceID=0x%x",
+	PMD_INIT_LOG(DEBUG, "port_id %d vendorID=0x%x deviceID=0x%x",
 		     eth_dev->data->port_id, pci_dev->id.vendor_id,
 		     pci_dev->id.device_id);
 
@@ -1305,9 +1305,10 @@ eth_em_interrupt_action(struct rte_eth_dev *dev)
 	} else {
 		PMD_INIT_LOG(INFO, " Port %d: Link Down", dev->data->port_id);
 	}
-	PMD_INIT_LOG(INFO, "PCI Address: %04d:%02d:%02d:%d",
+	PMD_INIT_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d",
 		     dev->pci_dev->addr.domain, dev->pci_dev->addr.bus,
 		     dev->pci_dev->addr.devid, dev->pci_dev->addr.function);
+
 	tctl = E1000_READ_REG(hw, E1000_TCTL);
 	rctl = E1000_READ_REG(hw, E1000_RCTL);
 	if (link.link_status) {
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 11e8ab8..cc8bfae 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -588,7 +588,7 @@ eth_igb_dev_init(struct rte_eth_dev *eth_dev)
 	E1000_WRITE_REG(hw, E1000_CTRL_EXT, ctrl_ext);
 	E1000_WRITE_FLUSH(hw);
 
-	PMD_INIT_LOG(INFO, "port_id %d vendorID=0x%x deviceID=0x%x",
+	PMD_INIT_LOG(DEBUG, "port_id %d vendorID=0x%x deviceID=0x%x",
 		     eth_dev->data->port_id, pci_dev->id.vendor_id,
 		     pci_dev->id.device_id);
 
@@ -1925,7 +1925,8 @@ eth_igb_interrupt_action(struct rte_eth_dev *dev)
 			PMD_INIT_LOG(INFO, " Port %d: Link Down",
 				     dev->data->port_id);
 		}
-		PMD_INIT_LOG(INFO, "PCI Address: %04d:%02d:%02d:%d",
+
+		PMD_INIT_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d",
 			     dev->pci_dev->addr.domain,
 			     dev->pci_dev->addr.bus,
 			     dev->pci_dev->addr.devid,
-- 
2.1.4

  parent reply	other threads:[~2015-07-09 23:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 23:01 [dpdk-dev] [PATCH v3 0/6] log de-spamming Stephen Hemminger
2015-07-09 23:01 ` [dpdk-dev] [PATCH v3 1/6] ixgbe: convert debug messages to DEBUG level Stephen Hemminger
2015-07-09 23:01 ` [dpdk-dev] [PATCH v3 2/6] ixgbe: raise priority of significant log events Stephen Hemminger
2015-07-09 23:27   ` Thomas Monjalon
2015-07-09 23:39     ` Stephen Hemminger
2015-07-09 23:01 ` [dpdk-dev] [PATCH v3 3/6] ixgbe: allow pruning log during build Stephen Hemminger
2015-07-09 23:28   ` Thomas Monjalon
2015-07-30 17:31   ` Thomas Monjalon
2015-07-09 23:01 ` [dpdk-dev] [PATCH v3 4/6] e1000: " Stephen Hemminger
2015-07-09 23:01 ` Stephen Hemminger [this message]
2015-07-09 23:01 ` [dpdk-dev] [PATCH v3 6/6] e1000: raise log level of signifcant events Stephen Hemminger
2015-07-30 18:18 ` [dpdk-dev] [PATCH v3 0/6] log de-spamming Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436482868-7400-6-git-send-email-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=shemming@brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).