From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id C9AC25A0A for ; Wed, 15 Jul 2015 13:21:42 +0200 (CEST) Received: by wgkl9 with SMTP id l9so30889673wgk.1 for ; Wed, 15 Jul 2015 04:21:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=k7RiLDjGc/1hMZQL4oET07tqBTpOteyJ25hvcEenHs0=; b=NjBeGk6BHwBm5fs4yY+F+Du3zSaT+O9hVDa73A2p8Q8CYDMGQTjb4PG1Om4b3oEZM6 +38Xigfpgg4aaYhK9fmiiRy4DT6+jv/rerbfaQ9fSkpWYBEGr5Wk1ykZLj1W3zAdszmz D4IQBoSHK0yH0+IgVpoR/xnQcuu7cUWk+uhbDtUneDMrCoQm07s1JXQfMr7AvLzYgUY6 8qfHnF26//vuCmEOKPHVDGXtQPwyo/5tmQZFdgX8qN2tbJPRPL9nZWysAZHL6r6vJ3TC IP2AsDkziCy+exElLDugfWgn5R6PHcPL3odu4o056L1lX1G+R3e6IkvnC8aEyt4kMXX9 5W1A== X-Gm-Message-State: ALoCoQnHGlL4iUs523wpo85klPeC2nsEvYzc2M+3XfSGcKibvZLsdhMNNT6B91dxGU3xRh3qa+7P X-Received: by 10.194.187.51 with SMTP id fp19mr6921125wjc.67.1436959302662; Wed, 15 Jul 2015 04:21:42 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210]) by smtp.gmail.com with ESMTPSA id q9sm26176231wiz.23.2015.07.15.04.21.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jul 2015 04:21:41 -0700 (PDT) From: Thomas Monjalon To: "Wang, Liang-min" Date: Wed, 15 Jul 2015 13:20:30 +0200 Message-ID: <1436962741.PL5XZBfjSs@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <4907797.WMXsT5lYd9@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v15 1/4] ethdev: add apis to support access device info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2015 11:21:43 -0000 2015-07-15 10:48, Wang, Liang-min: > > > > What means magic? Is it always a device id? > > > This field is the same as defined in kernel ethtool data structure. > > > > Not an excellent argument :) > > Actually you didn't answer. > > > I could not speak for other devices. For igb and ixgbe, it's device id. > Based upon literature search, this field is used by device driver to provide extra information. > What would be your suggestion? I don't have any suggestion. You are defining a new API in DPDK, so our concern must be to check that it will be easily understood by users and PMD developers. If you don't really know what this field will be for, others won't know.