* [dpdk-dev] [PATCH] ethdev: fix macro VALID_PORTID_OR_ERR_RTE
@ 2015-07-15 17:22 Liang-Min Larry Wang
2015-07-16 21:51 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Liang-Min Larry Wang @ 2015-07-15 17:22 UTC (permalink / raw)
To: dev; +Cc: Liang-Min Larry Wang
fix return value, using the macro input instead of -EINVAL.
Signed-off-by: Liang-Min Larry Wang <liang-min.wang@intel.com>
---
lib/librte_ether/rte_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index ddf3658..a957d9a 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -111,7 +111,7 @@
#define VALID_PORTID_OR_ERR_RET(port_id, retval) do { \
if (!rte_eth_dev_is_valid_port(port_id)) { \
PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); \
- return -EINVAL; \
+ return retval; \
} \
} while (0)
--
2.1.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: fix macro VALID_PORTID_OR_ERR_RTE
2015-07-15 17:22 [dpdk-dev] [PATCH] ethdev: fix macro VALID_PORTID_OR_ERR_RTE Liang-Min Larry Wang
@ 2015-07-16 21:51 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2015-07-16 21:51 UTC (permalink / raw)
To: Liang-Min Larry Wang; +Cc: dev
2015-07-15 13:22, Liang-Min Larry Wang:
> fix return value, using the macro input instead of -EINVAL.
>
> Signed-off-by: Liang-Min Larry Wang <liang-min.wang@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-16 21:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-15 17:22 [dpdk-dev] [PATCH] ethdev: fix macro VALID_PORTID_OR_ERR_RTE Liang-Min Larry Wang
2015-07-16 21:51 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).