From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6764A5A0A for ; Wed, 15 Jul 2015 19:27:50 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 15 Jul 2015 10:27:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,481,1432623600"; d="scan'208";a="765079390" Received: from unknown (HELO Sent) ([10.217.248.180]) by orsmga002.jf.intel.com with SMTP; 15 Jul 2015 10:27:47 -0700 Received: by Sent (sSMTP sendmail emulation); Wed, 15 Jul 2015 19:27:25 +0200 From: Tomasz Kulasek To: dev@dpdk.org Date: Wed, 15 Jul 2015 19:26:22 +0200 Message-Id: <1436981189-3320-3-git-send-email-tomaszx.kulasek@intel.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com> References: <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com> <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com> Subject: [dpdk-dev] [PATCHv4 2/9] null: fix segfault when null_pmd added to bonding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2015 17:27:50 -0000 When device is added to the bonding, the link status callback is added to the slave's eth_dev->link_intr_cbs list. This list is not initialized for null pmd and adding it to the bonding segfaults application. This patch allocates and sets up required structures. Signed-off-by: Tomasz Kulasek --- drivers/net/null/rte_eth_null.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index e244595..a8b3191 100644 --- a/drivers/net/null/rte_eth_null.c +++ b/drivers/net/null/rte_eth_null.c @@ -386,6 +386,7 @@ eth_dev_null_create(const char *name, const unsigned nb_rx_queues = 1; const unsigned nb_tx_queues = 1; struct rte_eth_dev_data *data = NULL; + struct eth_driver *eth_drv = NULL; struct rte_pci_device *pci_dev = NULL; struct pmd_internals *internals = NULL; struct rte_eth_dev *eth_dev = NULL; @@ -416,6 +417,10 @@ eth_dev_null_create(const char *name, if (eth_dev == NULL) goto error; + eth_drv = rte_zmalloc_socket(name, sizeof(*eth_drv), 0, numa_node); + if (!eth_drv) + goto error; + /* now put it all together * - store queue data in internals, * - store numa_node info in pci_driver @@ -431,7 +436,10 @@ eth_dev_null_create(const char *name, internals->packet_copy = packet_copy; internals->numa_node = numa_node; + eth_drv->pci_drv.name = drivername; + pci_dev->numa_node = numa_node; + pci_dev->driver = ð_drv->pci_drv; data->dev_private = internals; data->port_id = eth_dev->data->port_id; @@ -445,6 +453,7 @@ eth_dev_null_create(const char *name, eth_dev->dev_ops = &ops; eth_dev->pci_dev = pci_dev; eth_dev->driver = &rte_null_pmd; + TAILQ_INIT(ð_dev->link_intr_cbs); /* finally assign rx and tx ops */ if (packet_copy) { @@ -461,6 +470,8 @@ error: rte_free(data); rte_free(pci_dev); rte_free(internals); + rte_free(eth_dev); + rte_free(eth_drv); return -1; } -- 1.7.9.5