From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stephen@networkplumber.org> Received: from mail-pd0-f180.google.com (mail-pd0-f180.google.com [209.85.192.180]) by dpdk.org (Postfix) with ESMTP id 9A8E45A51 for <dev@dpdk.org>; Fri, 17 Jul 2015 00:05:10 +0200 (CEST) Received: by pdbqm3 with SMTP id qm3so50767134pdb.0 for <dev@dpdk.org>; Thu, 16 Jul 2015 15:05:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gdtLciwjwl4DTPsk0ybOj3Vpf4TbPBgy+FOKmkxJ50M=; b=WjLpFJ4cWn3t4uva+hye2WmA9i31QnCeXK2+LYe9VhVP0QizeLRlpcE5iZ3iF6Spod i+c7MHLUAB1sbjqsEieNYqWQLPSzzlyyihSSYRyD5I0xQU6AB14eAT+FfHF7LiLguopo 6x9sSHDAuhXh+RtqJLEXs1bN+SAkVhNt3YtaUkwzSoNkndJP0lhuGRSNtcbnTVa409o8 RH+XPWO9EVvbe2jK7bL/0zgza79xfEUk0Y3+ilwWN9NdatKX3+gTtpyEOnjeXNEt6UN8 w07QPNF0a4l9Kx4rIm7wPBp9n0UgTl3dLvH3BJq4lzdRCGyu+hLocvx40MprP3Oe7r2s Peyg== X-Gm-Message-State: ALoCoQlVL251gpr/wIs6ErWK76O0w0TbEbRECwc9cQrxYnpPlnn4Bx0PQJeLKVJisWGspe1gr5nO X-Received: by 10.70.37.207 with SMTP id a15mr22910996pdk.4.1437084309893; Thu, 16 Jul 2015 15:05:09 -0700 (PDT) Received: from urahara.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id fr2sm9006009pdb.22.2015.07.16.15.05.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 16 Jul 2015 15:05:09 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> To: Jing Chen <jing.d.chen@intel.com> Date: Thu, 16 Jul 2015 15:05:17 -0700 Message-Id: <1437084317-13942-1-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH] fm10k: remove useless code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 16 Jul 2015 22:05:11 -0000 The return in fm10k_dev_handle_fault has useless conditional since it always returns 0 here. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- drivers/net/fm10k/fm10k_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 902ccae..493b6f9 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -1793,8 +1793,6 @@ fm10k_dev_handle_fault(struct fm10k_hw *hw, uint32_t eicr) fault.address, fault.specinfo); } - if (estr) - return 0; return 0; error: PMD_INIT_LOG(ERR, "Failed to handle fault event."); -- 2.1.4