Re: [dpdk-dev] [PATCH] ixgbe: reset hardware stat when initialize

Re: [dpdk-dev] [PATCH] ixgbe: reset hardware stat when initialize

[Qiu, Michael]

Any comments about this patch?

Thanks,
Michael

On 5/8/2015 4:14 PM, Michael Qiu wrote:
> From: Michael Qiu <michael.qiu@intel.com>
>
> When initialize the hardware, the stat should be reset.
> Otherwise when detach then attach port, the stat will not
> be re-init to zero.
>
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
>  lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> index 1b3b4b5..dbcc12a 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> @@ -840,6 +840,9 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev)
>  		return -EIO;
>  	}
>  
> +	/* Reset the hw statistics */
> +	ixgbe_dev_stats_reset(eth_dev);
> +
>  	/* disable interrupt */
>  	ixgbe_disable_intr(hw);
>  
> @@ -1015,6 +1018,9 @@ eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev)
>  	/* Disable the interrupts for VF */
>  	ixgbevf_intr_disable(hw);
>  
> +	/* Reset the hw statistics */
> +	ixgbevf_dev_stats_reset(eth_dev);
> +
>  	hw->mac.num_rar_entries = 128; /* The MAX of the underlying PF */
>  	diag = hw->mac.ops.reset_hw(hw);
>  

[dpdk-dev] [PATCH v2] ixgbe: reset hardware stat when initialize

[Michael Qiu]

When initialize the hardware, the stat should be reset.
Otherwise when detach then attach port, the stat will not
be re-init to zero.

Signed-off-by: Michael Qiu <michael.qiu@intel.com>
---
Change log:
	v2 --> v1:
	change the folder of driver

 drivers/net/ixgbe/ixgbe_ethdev.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 0d9f9b2..e0415a7 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -840,6 +840,9 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev)
 		return -EIO;
 	}
 
+	/* Reset the hw statistics */
+	ixgbe_dev_stats_reset(eth_dev);
+
 	/* disable interrupt */
 	ixgbe_disable_intr(hw);
 
@@ -1012,6 +1015,9 @@ eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev)
 	/* init_mailbox_params */
 	hw->mbx.ops.init_params(hw);
 
+	/* Reset the hw statistics */
+	ixgbevf_dev_stats_reset(eth_dev);
+
 	/* Disable the interrupts for VF */
 	ixgbevf_intr_disable(hw);
 
-- 
1.9.3

Re: [dpdk-dev] [PATCH v2] ixgbe: reset hardware stat when initialize

[Iremonger, Bernard]

> -----Original Message-----
> From: Qiu, Michael
> Sent: Thursday, June 11, 2015 8:30 AM
> To: dev@dpdk.org
> Cc: Iremonger, Bernard; thomas.monjalon@6wind.com; Qiu, Michael
> Subject: [PATCH v2] ixgbe: reset hardware stat when initialize
> 
> When initialize the hardware, the stat should be reset.
> Otherwise when detach then attach port, the stat will not be re-init to zero.
> 
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com>

Re: [dpdk-dev] [PATCH v2] ixgbe: reset hardware stat when initialize

[Qiu, Michael]

Hi, all

Any comments  on this patch?

Thanks,
Michael

On 6/22/2015 8:47 PM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: Qiu, Michael
>> Sent: Thursday, June 11, 2015 8:30 AM
>> To: dev@dpdk.org
>> Cc: Iremonger, Bernard; thomas.monjalon@6wind.com; Qiu, Michael
>> Subject: [PATCH v2] ixgbe: reset hardware stat when initialize
>>
>> When initialize the hardware, the stat should be reset.
>> Otherwise when detach then attach port, the stat will not be re-init to zero.
>>
>> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
>> ---
> Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com>
>
>

Re: [dpdk-dev] [PATCH v2] ixgbe: reset hardware stat when initialize

[Thomas Monjalon]

> > When initialize the hardware, the stat should be reset.
> > Otherwise when detach then attach port, the stat will not be re-init to zero.
> > 
> > Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> 
> Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com>

Applied, thanks