DPDK patches and discussions
 help / color / mirror / Atom feed
From: Konstantin Ananyev <konstantin.ananyev@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCHv2 0/5] ixgbe: fix mbuf release on RX and TX
Date: Fri, 24 Jul 2015 14:58:10 +0100	[thread overview]
Message-ID: <1437746295-12184-1-git-send-email-konstantin.ananyev@intel.com> (raw)
In-Reply-To: <1437667506-3890-2-git-send-email-bruce.richardson@intel.com>
In-Reply-To: <1437667506-3890-2-git-send-email-bruce.richardson@intel.com>

Konstantin has correctly pointed out that the previously applied fix:
b35d0d80f0a8 ("ixgbe: check mbuf refcnt when clearing a ring")
is not a proper fix for the reported issue at all.
Ref: http://permalink.gmane.org/gmane.comp.networking.dpdk.devel/21932

This patch set reverts the original fix, and applies a better fix for the
issue, as well as performing other cleanups in the code in question, to
try and avoid future issues.

v2 chages:
- Make sure that rx_using_sse is reset to zero if scalar RX function was chosen.
- fix checkpatch.pl errors.
- fix remaining wrong typecast.

Konstantin Ananyev (5):
  Revert "ixgbe: check mbuf refcnt when clearing a ring"
  ixgbe: fix comments on rx_queue fields
  ixgbe: fix bug on release of mbufs from queue
  ixgbe: rename tx queue release function for consistency
  ixgbe: remove awkward typecasts from ixgbe SSE PMD

 drivers/net/ixgbe/ixgbe_rxtx.c     | 23 ++++++++++-
 drivers/net/ixgbe/ixgbe_rxtx.h     | 12 ++++--
 drivers/net/ixgbe/ixgbe_rxtx_vec.c | 80 +++++++++++++++++++++-----------------
 3 files changed, 75 insertions(+), 40 deletions(-)

-- 
1.8.3.1

  reply	other threads:[~2015-07-24 13:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 16:05 [dpdk-dev] [PATCH " Bruce Richardson
2015-07-23 16:05 ` [dpdk-dev] [PATCH 1/5] Revert "ixgbe: check mbuf refcnt when clearing a ring" Bruce Richardson
2015-07-24 13:58   ` Konstantin Ananyev [this message]
2015-07-24 13:58     ` [dpdk-dev] [PATCHv2 " Konstantin Ananyev
2015-07-24 15:30       ` Zhang, Helin
2015-07-24 13:58     ` [dpdk-dev] [PATCHv2 2/5] ixgbe: fix comments on rx_queue fields Konstantin Ananyev
2015-07-24 13:58     ` [dpdk-dev] [PATCHv2 3/5] ixgbe: fix bug on release of mbufs from queue Konstantin Ananyev
2015-07-24 13:58     ` [dpdk-dev] [PATCHv2 4/5] ixgbe: rename tx queue release function for consistency Konstantin Ananyev
2015-07-24 15:32       ` Zhang, Helin
2015-07-24 13:58     ` [dpdk-dev] [PATCHv2 5/5] ixgbe: remove awkward typecasts from ixgbe SSE PMD Konstantin Ananyev
2015-07-26  8:48     ` [dpdk-dev] [PATCHv2 0/5] ixgbe: fix mbuf release on RX and TX Thomas Monjalon
2015-07-23 16:05 ` [dpdk-dev] [PATCH 2/5] ixgbe: fix comments on rx_queue fields Bruce Richardson
2015-07-23 16:05 ` [dpdk-dev] [PATCH 3/5] ixgbe: fix bug on release of mbufs from queue Bruce Richardson
2015-07-23 16:05 ` [dpdk-dev] [PATCH 4/5] ixgbe: rename tx queue release function for consistency Bruce Richardson
2015-07-23 16:05 ` [dpdk-dev] [PATCH 5/5] ixgbe: remove awkward typecasts from ixgbe SSE PMD Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437746295-12184-1-git-send-email-konstantin.ananyev@intel.com \
    --to=konstantin.ananyev@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).