From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 02/11] eth: do simple return
Date: Fri, 24 Jul 2015 10:06:15 -0700 [thread overview]
Message-ID: <1437757584-15502-3-git-send-email-stephen@networkplumber.org> (raw)
In-Reply-To: <1437757584-15502-1-git-send-email-stephen@networkplumber.org>
Found by coccinelle simple_return.cocci
This function can just use direct return.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/librte_ether/rte_ethdev.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index f46426e..a96cd4f 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -269,17 +269,12 @@ static int
rte_eth_dev_create_unique_device_name(char *name, size_t size,
struct rte_pci_device *pci_dev)
{
- int ret;
-
if ((name == NULL) || (pci_dev == NULL))
return -EINVAL;
- ret = snprintf(name, size, "%d:%d.%d",
+ return snprintf(name, size, "%d:%d.%d",
pci_dev->addr.bus, pci_dev->addr.devid,
pci_dev->addr.function);
- if (ret < 0)
- return ret;
- return 0;
}
int
--
2.1.4
next prev parent reply other threads:[~2015-07-24 17:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 17:06 [dpdk-dev] [PATCH 00/11] misc cleanup patches Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 01/11] eth: move queue check for rx_queue_count Stephen Hemminger
2015-07-26 13:47 ` Thomas Monjalon
2015-08-03 17:00 ` Zhang, Helin
2015-07-24 17:06 ` Stephen Hemminger [this message]
2015-07-24 17:06 ` [dpdk-dev] [PATCH 03/11] kni: remove useless semicolon Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 04/11] eth: remove unnecessary return value Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 05/11] kni: eliminate unnecessary return variables Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 06/11] pipeline: remove useless cast Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 07/11] lpm: remove useless casts Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 08/11] hash: " Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 09/11] kni: remove useless cast Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 10/11] i40e: " Stephen Hemminger
2015-08-03 16:56 ` Zhang, Helin
2015-07-24 17:06 ` [dpdk-dev] [PATCH 11/11] bond: " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437757584-15502-3-git-send-email-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).