DPDK patches and discussions
 help / color / mirror / Atom feed
From: Wang Xiao W <xiao.w.wang@intel.com>
To: dev@dpdk.org
Cc: Wang Xiao W <xiao.w.wang@intel.com>
Subject: [dpdk-dev] [PATCH 14/16] fm10k: remove err_no reference
Date: Mon, 27 Jul 2015 16:42:37 +0800	[thread overview]
Message-ID: <1437986559-31016-14-git-send-email-xiao.w.wang@intel.com> (raw)
In-Reply-To: <1437986559-31016-1-git-send-email-xiao.w.wang@intel.com>

The reference to err_no was left around after an old re-factor. We never
use this value again, and the macros called on the function appear to
have no relevant side effect I could see. Discovered via cppcheck
fm10k_mbx.c:1312: (style) Variable 'err_no' is assigned a value that is never used.

This occurred because a previous commit refactored and removed all used
references to err_no.

Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
---
 drivers/net/fm10k/base/fm10k_mbx.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/fm10k/base/fm10k_mbx.c b/drivers/net/fm10k/base/fm10k_mbx.c
index 0cdd24d..ad9d81a 100644
--- a/drivers/net/fm10k/base/fm10k_mbx.c
+++ b/drivers/net/fm10k/base/fm10k_mbx.c
@@ -1292,16 +1292,11 @@ STATIC s32 fm10k_mbx_process_error(struct fm10k_hw *hw,
 				   struct fm10k_mbx_info *mbx)
 {
 	const u32 *hdr = &mbx->mbx_hdr;
-	s32 err_no;
 	u16 head;
 
 	/* we will need to pull all of the fields for verification */
 	head = FM10K_MSG_HDR_FIELD_GET(*hdr, HEAD);
 
-	/* we only have lower 10 bits of error number so add upper bits */
-	err_no = FM10K_MSG_HDR_FIELD_GET(*hdr, ERR_NO);
-	err_no |= ~FM10K_MSG_HDR_MASK(ERR_NO);
-
 	switch (mbx->state) {
 	case FM10K_STATE_OPEN:
 	case FM10K_STATE_DISCONNECT:
-- 
1.9.3

  parent reply	other threads:[~2015-07-27  8:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27  8:42 [dpdk-dev] [PATCH 01/16] fm10k: add PF Tx Timestamp mode handler function Wang Xiao W
2015-07-27  8:42 ` [dpdk-dev] [PATCH 02/16] fm10k: add no-op pointer for VF request_tx_timestamp_mode Wang Xiao W
2015-07-27  8:42 ` [dpdk-dev] [PATCH 03/16] fm10k: Set PF queues to unlimited bandwidth Wang Xiao W
2015-07-27  8:42 ` [dpdk-dev] [PATCH 04/16] fm10k: fix fm10k_mbx_write_copy header comment Wang Xiao W
2015-07-27  8:42 ` [dpdk-dev] [PATCH 05/16] fm10k: Add support for ITR scaling based on PCIe link speed Wang Xiao W
2015-07-27  8:42 ` [dpdk-dev] [PATCH 06/16] fm10k: reset head instead of calling update_max_size Wang Xiao W
2015-07-27  8:42 ` [dpdk-dev] [PATCH 07/16] fm10k: mbx_update_max_size does not drop all Wang Xiao W
2015-07-27  8:42 ` [dpdk-dev] [PATCH 08/16] fm10k: ensure VF restores itr_scale on stop_hw Wang Xiao W
2015-07-27  8:42 ` [dpdk-dev] [PATCH 09/16] fm10k: ensure itr_scale is set even if we don't know speed Wang Xiao W
2015-07-27  8:42 ` [dpdk-dev] [PATCH 10/16] fm10k: correct VF multicast update Wang Xiao W
2015-07-27  8:42 ` [dpdk-dev] [PATCH 11/16] fm10k: Re-map all possible VF queues after a VFLR Wang Xiao W
2015-07-27  8:42 ` [dpdk-dev] [PATCH 12/16] fm10k: pack TLV overlay structures correctly Wang Xiao W
2015-07-27  8:42 ` [dpdk-dev] [PATCH 13/16] fm10k: 1558 DIR_NEGATIVE bit is actually DIR_POSITIVE Wang Xiao W
2015-07-27  8:42 ` Wang Xiao W [this message]
2015-07-27  8:42 ` [dpdk-dev] [PATCH 15/16] fm10k: fix iov_msg_lport_state_pf re-enable bug Wang Xiao W
2015-07-27  8:42 ` [dpdk-dev] [PATCH 16/16] fm10k: add macro definitions about valid ether addr Wang Xiao W

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437986559-31016-14-git-send-email-xiao.w.wang@intel.com \
    --to=xiao.w.wang@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).