From: Jingjing Wu <jingjing.wu@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3] i40evf: fix crash when setup tx queues on vf port
Date: Wed, 29 Jul 2015 08:54:57 +0800 [thread overview]
Message-ID: <1438131297-22750-1-git-send-email-jingjing.wu@intel.com> (raw)
In-Reply-To: <1438074060-13809-1-git-send-email-jingjing.wu@intel.com>
This patch fixes the issue:
Testpmd crashed with Segmentation fault when setup tx queues on vf
Steps for reproduce:
- create one vf device from i40e driver
- bind vf device to igb_uio and start testpmd
With debugging tools, we saw the struct i40e_vf is cleared after
memcpy(&dev->data->dev_conf, dev_conf, sizeof(dev->data->dev_conf)) in
rte_eth_dev_configure, which should not happen, and the pointer to
i40e_vf isn't in the range of i40e_adapter.
The root cause is the dev_private_size in i40e virtual function driver struct
rte_i40evf_pmd was set incorrectly.
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
v2 changes:
rework the patch's title and commit log.
V3 changes:
fix name in Signed-off-by.
drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index f3470e6..b694400 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -1248,7 +1248,7 @@ static struct eth_driver rte_i40evf_pmd = {
},
.eth_dev_init = i40evf_dev_init,
.eth_dev_uninit = i40evf_dev_uninit,
- .dev_private_size = sizeof(struct i40e_vf),
+ .dev_private_size = sizeof(struct i40e_adapter),
};
/*
--
2.4.0
next prev parent reply other threads:[~2015-07-29 0:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 1:13 [dpdk-dev] [PATCH] i40e: correct the private data size for i40e vf driver Jingjing Wu
2015-07-28 1:27 ` Liu, Yong
2015-07-28 8:11 ` Thomas Monjalon
2015-07-28 9:01 ` [dpdk-dev] [PATCH V2] i40evf: fix crash when setup tx queues on vf port Jingjing Wu
2015-07-29 0:54 ` Jingjing Wu [this message]
2015-07-29 22:33 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2015-07-30 0:41 ` Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438131297-22750-1-git-send-email-jingjing.wu@intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).