[dpdk-dev] config files maintenance

[dpdk-dev] config files maintenance

[Thomas Monjalon]

Hi,

Currently most of the build options are duplicated in 2 config files.
They should be merged in a common file to avoid this kind of differences:

--- config/common_bsdapp
+++ config/common_linuxapp
-CONFIG_RTE_IXGBE_INC_VECTOR=n
+CONFIG_RTE_IXGBE_INC_VECTOR=y
-CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE=n
+CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=y
-CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=n
+CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y

Can we enable ixgbe SSE on BSD?
CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE must be renamed to
CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE, or can we remove this option?
Can we remove i40e bulk alloc option?
Why IEEE1588 is disabled? Can we remove this option?

Please help to fix it for the release 2.1.

After fixing the config, we have to think about simplifying it in 2.2.
It would be easier to have some kind of config overlays:
	config_base
	config_bsd
	config_linux
	config_osv
	config_gcc
	config_icc
	config_clang
	config_i686
	config_x86_64
	config_x86_x32
	config_ppc_64
	config_tile-tilegx
Then the defconfig files would include the above files.
Or better, we could allow some paramaters to make config:
	make config ARCH= OS= CC=

Thoughts?

Re: [dpdk-dev] config files maintenance

[Zhang, Helin]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, July 31, 2015 8:08 AM
> To: Zhang, Helin; Ananyev, Konstantin; Richardson, Bruce
> Cc: dev@dpdk.org
> Subject: config files maintenance
> 
> Hi,
> 
> Currently most of the build options are duplicated in 2 config files.
> They should be merged in a common file to avoid this kind of differences:
> 
> --- config/common_bsdapp
> +++ config/common_linuxapp
> -CONFIG_RTE_IXGBE_INC_VECTOR=n
> +CONFIG_RTE_IXGBE_INC_VECTOR=y
> -CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE=n
> +CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=y
> -CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=n
> +CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y
> 
> Can we enable ixgbe SSE on BSD?
> CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE must be renamed to
> CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE, or can we remove this option?
> Can we remove i40e bulk alloc option?
As the receiving functions are different for bulk_alloc or not, we need this flag.

> Why IEEE1588 is disabled? Can we remove this option?
I think the reason was it wanted to show the best performance by default,
as more processing are needed for ieee1588 in fast path.
I agree with you that we may need to re-think it.

Thanks,
Helin

> 
> Please help to fix it for the release 2.1.
> 
> After fixing the config, we have to think about simplifying it in 2.2.
> It would be easier to have some kind of config overlays:
> 	config_base
> 	config_bsd
> 	config_linux
> 	config_osv
> 	config_gcc
> 	config_icc
> 	config_clang
> 	config_i686
> 	config_x86_64
> 	config_x86_x32
> 	config_ppc_64
> 	config_tile-tilegx
> Then the defconfig files would include the above files.
> Or better, we could allow some paramaters to make config:
> 	make config ARCH= OS= CC=
> 
> Thoughts?

Re: [dpdk-dev] config files maintenance

[Thomas Monjalon]

2015-07-31 15:29, Zhang, Helin:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Can we remove i40e bulk alloc option?
> 
> As the receiving functions are different for bulk_alloc or not, we need this flag.

What brings the non bulk alloc function?
Why is it disabled for BSD?

Re: [dpdk-dev] config files maintenance

[Zhang, Helin]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, July 31, 2015 8:31 AM
> To: Zhang, Helin
> Cc: Ananyev, Konstantin; Richardson, Bruce; dev@dpdk.org
> Subject: Re: config files maintenance
> 
> 2015-07-31 15:29, Zhang, Helin:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > Can we remove i40e bulk alloc option?
> >
> > As the receiving functions are different for bulk_alloc or not, we need this flag.
> 
> What brings the non bulk alloc function?
Bulk-alloc means it will allocate mbufs in bulk, which was added before we supporting
Vector PMD long long ago, to show the possible better performance.
I think all was disabled by default, and later it is enabled by default for Linux.

> Why is it disabled for BSD?
So now the question is can it be enabled for BSD by default, right?
I guess yes, but others may give the accurate answer.

Regards,
Helin

Re: [dpdk-dev] config files maintenance

[Thomas Monjalon]

2015-07-31 15:39, Zhang, Helin:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2015-07-31 15:29, Zhang, Helin:
> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > > Can we remove i40e bulk alloc option?
> > >
> > > As the receiving functions are different for bulk_alloc or not, we need this flag.
> > 
> > What brings the non bulk alloc function?
> 
> Bulk-alloc means it will allocate mbufs in bulk, which was added before we supporting
> Vector PMD long long ago, to show the possible better performance.
> I think all was disabled by default, and later it is enabled by default for Linux.

Yes, I know that. My question was:
Why not removing the non bulk alloc Rx in i40e?
Who needs to disable I40E_RX_ALLOW_BULK_ALLOC?

I think you understand that the goal is remove some options and code
useless nowadays (maintenance stuff).

Re: [dpdk-dev] config files maintenance

[Zhang, Helin]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, July 31, 2015 8:43 AM
> To: Zhang, Helin
> Cc: Ananyev, Konstantin; Richardson, Bruce; dev@dpdk.org
> Subject: Re: config files maintenance
> 
> 2015-07-31 15:39, Zhang, Helin:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > 2015-07-31 15:29, Zhang, Helin:
> > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > > > Can we remove i40e bulk alloc option?
> > > >
> > > > As the receiving functions are different for bulk_alloc or not, we need this
> flag.
> > >
> > > What brings the non bulk alloc function?
> >
> > Bulk-alloc means it will allocate mbufs in bulk, which was added
> > before we supporting Vector PMD long long ago, to show the possible better
> performance.
> > I think all was disabled by default, and later it is enabled by default for Linux.
> 
> Yes, I know that. My question was:
> Why not removing the non bulk alloc Rx in i40e?
> Who needs to disable I40E_RX_ALLOW_BULK_ALLOC?
> 
> I think you understand that the goal is remove some options and code useless
> nowadays (maintenance stuff).

I remember that last time somebody else were discussing about removing that,
but finally gave up. Let me find out why they gave up, and then see if we can remove it later.

Thanks,
Helin

Re: [dpdk-dev] config files maintenance

[Ananyev, Konstantin]

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, July 31, 2015 4:08 PM
> To: Zhang, Helin; Ananyev, Konstantin; Richardson, Bruce
> Cc: dev@dpdk.org
> Subject: config files maintenance
> 
> Hi,
> 
> Currently most of the build options are duplicated in 2 config files.
> They should be merged in a common file to avoid this kind of differences:
> 
> --- config/common_bsdapp
> +++ config/common_linuxapp
> -CONFIG_RTE_IXGBE_INC_VECTOR=n
> +CONFIG_RTE_IXGBE_INC_VECTOR=y
> -CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE=n
> +CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=y
> -CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=n
> +CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y
> 
> Can we enable ixgbe SSE on BSD?

I think yes, though I never tried myself to run vecPMD on freebsd.

> CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE must be renamed to
> CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE, or can we remove this option?

I think we can remove RTE_IXGBE_RX_OLFLAGS_ENABLE.

Konstantin

> Can we remove i40e bulk alloc option?
> Why IEEE1588 is disabled? Can we remove this option?
> 
> Please help to fix it for the release 2.1.
> 
> After fixing the config, we have to think about simplifying it in 2.2.
> It would be easier to have some kind of config overlays:
> 	config_base
> 	config_bsd
> 	config_linux
> 	config_osv
> 	config_gcc
> 	config_icc
> 	config_clang
> 	config_i686
> 	config_x86_64
> 	config_x86_x32
> 	config_ppc_64
> 	config_tile-tilegx
> Then the defconfig files would include the above files.
> Or better, we could allow some paramaters to make config:
> 	make config ARCH= OS= CC=
> 
> Thoughts?

Re: [dpdk-dev] config files maintenance

[Thomas Monjalon]

2015-07-31 17:08, Thomas Monjalon:
> Can we enable ixgbe SSE on BSD?
> CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE must be renamed to
> CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE, or can we remove this option?
> Can we remove i40e bulk alloc option?
> Why IEEE1588 is disabled? Can we remove this option?

One more question:
Can we remove CONFIG_RTE_PMD_PACKET_PREFETCH (always enabled)?

[dpdk-dev] [PATCH 0/3] sync linux/bsd config options

[Thomas Monjalon]

Fix config options for ixgbe, i40e and KNI for BSD.

Thomas Monjalon (3):
  ixgbe: fix offload config option name
  config: enable same drivers options for linux and bsd
  config: remove kni options for bsd

 config/common_bsdapp      | 17 +++--------------
 doc/guides/nics/ixgbe.rst |  6 +++---
 2 files changed, 6 insertions(+), 17 deletions(-)

-- 
2.4.2

[dpdk-dev] [PATCH 1/3] ixgbe: fix offload config option name

[Thomas Monjalon]

The RX_OLFLAGS option was renamed from DISABLE to ENABLE in driver code
and linux config.
It is now renamed also in bsd config and documentation.

Fixes: 359f106a69a9 ("ixgbe: prefer enabling olflags rather than not disabling")

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 config/common_bsdapp      | 2 +-
 doc/guides/nics/ixgbe.rst | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/config/common_bsdapp b/config/common_bsdapp
index 2c6eb40..650de38 100644
--- a/config/common_bsdapp
+++ b/config/common_bsdapp
@@ -174,7 +174,7 @@ CONFIG_RTE_LIBRTE_IXGBE_DEBUG_TX_FREE=n
 CONFIG_RTE_LIBRTE_IXGBE_DEBUG_DRIVER=n
 CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n
 CONFIG_RTE_IXGBE_INC_VECTOR=n
-CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE=n
+CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=y
 
 #
 # Compile burst-oriented I40E PMD driver
diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst
index 62cc0aa..8cae299 100644
--- a/doc/guides/nics/ixgbe.rst
+++ b/doc/guides/nics/ixgbe.rst
@@ -95,7 +95,7 @@ Other features are supported using optional MACRO configuration. They include:
 
 *   HW extend dual VLAN
 
-*   Enabled by RX_OLFLAGS (RTE_IXGBE_RX_OLFLAGS_DISABLE=n)
+*   Enabled by RX_OLFLAGS (RTE_IXGBE_RX_OLFLAGS_ENABLE=y)
 
 
 To guarantee the constraint, configuration flags in dev_conf.rxmode will be checked:
@@ -154,13 +154,13 @@ Sample Application Notes
 testpmd
 ^^^^^^^
 
-By default, using CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE=n:
+By default, using CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=y:
 
 .. code-block:: console
 
     ./x86_64-native-linuxapp-gcc/app/testpmd -c 300 -n 4 -- -i --burst=32 --rxfreet=32 --mbcache=250 --txpt=32 --rxht=8 --rxwt=0 --txfreet=32 --txrst=32 --txqflags=0xf01
 
-When CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE=y, better performance can be achieved:
+When CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=n, better performance can be achieved:
 
 .. code-block:: console
 
-- 
2.4.2

[dpdk-dev] [PATCH 2/3] config: enable same drivers options for linux and bsd

[Thomas Monjalon]

Enable vector ixgbe and i40e bulk alloc for bsd as it is
already done for linux.

Fixes: 304caba12643 ("config: fix bsd options")
Fixes: 0ff3324da2eb ("ixgbe: rework vector pmd following mbuf changes")

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 config/common_bsdapp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/config/common_bsdapp b/config/common_bsdapp
index 650de38..1e0c625 100644
--- a/config/common_bsdapp
+++ b/config/common_bsdapp
@@ -173,7 +173,7 @@ CONFIG_RTE_LIBRTE_IXGBE_DEBUG_TX=n
 CONFIG_RTE_LIBRTE_IXGBE_DEBUG_TX_FREE=n
 CONFIG_RTE_LIBRTE_IXGBE_DEBUG_DRIVER=n
 CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n
-CONFIG_RTE_IXGBE_INC_VECTOR=n
+CONFIG_RTE_IXGBE_INC_VECTOR=y
 CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=y
 
 #
@@ -185,7 +185,7 @@ CONFIG_RTE_LIBRTE_I40E_DEBUG_RX=n
 CONFIG_RTE_LIBRTE_I40E_DEBUG_TX=n
 CONFIG_RTE_LIBRTE_I40E_DEBUG_TX_FREE=n
 CONFIG_RTE_LIBRTE_I40E_DEBUG_DRIVER=n
-CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=n
+CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y
 CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n
 CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=4
 CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM=4
-- 
2.4.2

[dpdk-dev] [PATCH 3/3] config: remove kni options for bsd

[Thomas Monjalon]

KNI is a Linux-only kernel module.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 config/common_bsdapp | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/config/common_bsdapp b/config/common_bsdapp
index 1e0c625..b37dcf4 100644
--- a/config/common_bsdapp
+++ b/config/common_bsdapp
@@ -414,17 +414,6 @@ CONFIG_RTE_LIBRTE_PIPELINE=y
 CONFIG_RTE_PIPELINE_STATS_COLLECT=n
 
 #
-# Compile librte_kni
-#
-CONFIG_RTE_LIBRTE_KNI=n
-CONFIG_RTE_KNI_KO_DEBUG=n
-CONFIG_RTE_KNI_VHOST=n
-CONFIG_RTE_KNI_VHOST_MAX_CACHE_SIZE=1024
-CONFIG_RTE_KNI_VHOST_VNET_HDR_EN=n
-CONFIG_RTE_KNI_VHOST_DEBUG_RX=n
-CONFIG_RTE_KNI_VHOST_DEBUG_TX=n
-
-#
 # Enable warning directives
 #
 CONFIG_RTE_INSECURE_FUNCTION_WARNING=n
-- 
2.4.2

Re: [dpdk-dev] [PATCH 3/3] config: remove kni options for bsd

[Zhang, Helin]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, July 31, 2015 2:12 PM
> To: Zhang, Helin; Ananyev, Konstantin; Richardson, Bruce
> Cc: dev@dpdk.org
> Subject: [PATCH 3/3] config: remove kni options for bsd
> 
> KNI is a Linux-only kernel module.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>

Re: [dpdk-dev] [PATCH 0/3] sync linux/bsd config options

[Thomas Monjalon]

> Fix config options for ixgbe, i40e and KNI for BSD.
> 
> Thomas Monjalon (3):
>   ixgbe: fix offload config option name
>   config: enable same drivers options for linux and bsd
>   config: remove kni options for bsd

Applied