From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 645D942C53; Wed, 7 Jun 2023 20:42:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41901427E9; Wed, 7 Jun 2023 20:42:04 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2042.outbound.protection.outlook.com [40.107.220.42]) by mails.dpdk.org (Postfix) with ESMTP id 6DE6F41611 for ; Wed, 7 Jun 2023 20:42:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SV7/KBNbioHbtMC1wLMjRWHsY3in/5tObAfplRrtCTt8KwDnQssjJZ0DTcwZ4JSTaHNRy3gkVFGadun2TxAiE90FXQjt7iyiDI3lDua2/twPn63Y+Gfv6l10DJRyhU5IvAPmG0pF1u5UOaq6xoEECXkvy/D0B9VeiBssJqoiv4PLpCm81qYeABVGm6UvH1UFEHUuZHD7t4m5rLSYbh/TsjioGIlxX9m8e9dj8YS0s89ceXrLyosrIUT9X/2zJ/B6Pc3mCjQfuSSRxeaINyz7C54vGDF83ZPHX8aGt+tgBWiExRKWo7jo6o0w4xpNgjDEW6bdYGRE/XOFGofrai1iaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GlWN+FD0b1RP4MqDSj8lrUKXJjZEdxXKhVGx4m+Bfzo=; b=iTxcdFVBQfvnsl4OCRO6tHlDc9greYRLOsio9J4Mbi/63crCNuKKcKKxZourFNO8y9MfxSDocGUniKRHFsX+FwjBi4OcY6J6F+DlDRwLpJZEMu3doCemQ+exivrVK9hEAXM92Z2NYeXIZsSd52FSEpj8PMStFr8YgIfVkPYr5+qnr73BVxWphuE72mAWzDbv94pVbK51983PSPWP/cWD0Hg6s4+MIRSkfP4pIunxJazE2hMAxbxYKUrqUPmmD9Vr02NmTNkA2f3qmUePQmHkS80zalYwlMGkhDkXRAr5Xlb5D2nvjkhdxgsHXYLVCaxDg/aURwKPcL017axtTvLZ4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GlWN+FD0b1RP4MqDSj8lrUKXJjZEdxXKhVGx4m+Bfzo=; b=BxKp8skX5sycCmce+l1sn56IVpLIZoag2pG8A6qGCsdYXGuwCPIhiOxqrpuEXJJ1i2RED1LRONg88fPqG3k3qyYt5Ya0V/Iu1YvFiVWA533zV5+eSAzbvhxyAFGnR58z0qPleSqFNRBRk5e6I2+MkVy2AO3Rqc25YsDh6e6tk5U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA0PR12MB8302.namprd12.prod.outlook.com (2603:10b6:208:40f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.36; Wed, 7 Jun 2023 18:42:00 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6455.037; Wed, 7 Jun 2023 18:41:57 +0000 Message-ID: <14383e98-acd6-665a-1ad1-f784825bd998@amd.com> Date: Wed, 7 Jun 2023 19:41:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [RFC PATCH v2 0/3] improve FEC API usage Content-Language: en-US From: Ferruh Yigit To: Denis Pryazhennikov , dev@dpdk.org Cc: Ivan Malov , Viacheslav Galaktionov , Thomas Monjalon , Andrew Rybchenko , "Min Hu (Connor)" , "Wei Hu (Xavier)" , Chengwen Feng , Chengchang Tang , Ajit Khaparde References: <20230428102728.51956-1-denis.pryazhennikov@arknetworks.am> <20230508114707.89629-1-denis.pryazhennikov@arknetworks.am> <080a8617-0f93-e1f0-afc6-de6503d572c6@amd.com> In-Reply-To: <080a8617-0f93-e1f0-afc6-de6503d572c6@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0229.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:315::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB8302:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c09e026-7c35-4e65-b9ce-08db6786df45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W9GZCuhIu/7csSA+GE6YdH8PFK6Bqi0fmSaPZ7f82ecAv0lhWJuN+epEbzuuQX5nOjxU7EU+FLAob9t+sM5ScUUoc9/sw2OuUfGg9A1+KynYIQ8efzLnkwSc7moCDNIXlTwNrP93cS9qU5l3Ob8uqEX14xwi50RtA+swHEpqlqg2k4fGqgjPcgCWIGBs5TAxZwXsM5gMfMRs7gVJFISepN1hqofnTl7d4eMC0b08yuhNdzxQJ2yFZgtKsEw61jfjQIjBVDSzdMtVrQfuioEZBYwOVnVBChNttITrqKpOPGKoamlSXfk9dKcz5aO316kG6tTPoFDhOXpRwfOuowFQ874pl0p/OX+3RZ2Orp3U0fFHuwgAdewNCKWrxBe8o2f5QpKtsRoM45nkZRi/zWDOdBhj8z6zTt3KhxBBEMxuuNi7ecVGM64LiK6NqWW9aBIh7yOgZM4zCYDW0ADmNxZAMhS/Y9Y0gMS3wA2JIWmROCdhSe0AG8WLRUVXvPoRlO7lKlwahXa7AoJ3GtgSk/a0UYnI54cnbigdBAGDmNtUzoDA6kdQL9+wLHp0yk/j9b+WZizd7Dwwbn2YQDkBsG/lLxkLuwvQZcgFUTD/buz+9JlAKeHsF7xNw9irX4VltB8YGEL25lvM8rJ6ItwK5w6HAA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(396003)(346002)(136003)(39860400002)(376002)(451199021)(31686004)(26005)(6512007)(186003)(41300700001)(5660300002)(6506007)(53546011)(36756003)(7416002)(44832011)(4326008)(316002)(66556008)(66476007)(6666004)(66946007)(8676002)(8936002)(83380400001)(2616005)(478600001)(54906003)(31696002)(86362001)(2906002)(6486002)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDVBNWhsNUVZcm1LVUxycW5BWlFDamZmK3FNbkRtZUxhbUhQK0tCb2hQa3NF?= =?utf-8?B?elFFeW5EQmpMR0lNQ21vQXJxY0thcVIrRG0rOVhOdWp0NTRacERBZnpCazgv?= =?utf-8?B?dnNVRUwwQTByUjFTVGNsR0pUWEY3ZTk4VlhmVWJQT0tBWmUvZ0MxaHp3d0tY?= =?utf-8?B?VnFpcnE5aUZGUHh6dG50MjAwb3phWkZHc2FFeEljYS82SURYNHViVExCNFZI?= =?utf-8?B?am5yQW4yMzEwWGgxVFk5OHdSNmpKdTZmd1V5d3VraFZUWjBkNlprcTZJcGYw?= =?utf-8?B?YXdzUjA4a0MrMGFHQWhEQWVEbS9iaU82b04wK1dKZmJKa3pWcFRVOGJlMDNJ?= =?utf-8?B?djROdXRTbVE2Vmw1RldpaVh4RUt3ZXJOekU1RzRUbjd5ekUyck16TEU3SmFX?= =?utf-8?B?WWlpV0d4QnBralB0THFnNEV6eXJQSlBVbCtHM1NIWGZYMTlIWVhJMDdrbldR?= =?utf-8?B?SFZvUDdCSFI3Y0R6WnduRVZ5dTJUdXA0MHFTYWU0a2JqUVJiT3QvMDhYRjFh?= =?utf-8?B?NTQzQmc0aFZLbWRGRERzc1p6TzFhVkZtQlVWZmxVelMyNzRDQ0hXK01DM3pp?= =?utf-8?B?WFRPK25hd3M0YTYrWVlxUVBxTXNrRFZDQlJyQzZRZ1FwZU9IR3hxUy9pRzc4?= =?utf-8?B?d3NiUXBYRlBseTJ3Rmk3TzFhLzRXUUhoM1ptL0pobDZTREp4ZE83Qm1UM1pQ?= =?utf-8?B?NUJma3h5TXRMbDJTbjRwQmNQdk1WY1lqcHlmWkYvdHVMSDBnUUNaekk1ZXRa?= =?utf-8?B?N0hkYU1Ta3p2T2VKa0dQOVB6QUpnQ2lqOXZTSzBCSVI2d29CUHdEc1V2citw?= =?utf-8?B?STRsSDdTSExCcEIyQmh6T1o5WXhrMVQ3S1JaYTl2SWN2Z0t0bUlLemZpOGlS?= =?utf-8?B?M21vN1VDdTRWYVAzb1Zka2RJdFdyN3RLVUZ4ditKOFNXK3dGSXZBeTVRUFBJ?= =?utf-8?B?ZjlHNjh0ajQ2bU50d3EwTWR1bjJFZVZGL29UcFh1cVNzSmZvODdjTWdQOWRl?= =?utf-8?B?bHAyRkg2S0lVVlFWQzMxWllHZjF1aFNHYnRxUDdJV0xwa2dMOEtDeDRFZGJn?= =?utf-8?B?QmhTZjZBV1puOFlscVl0L1Rvd3FvN3JxeXlENHNhM0NMWXFKaW40TXJaSm1Q?= =?utf-8?B?NFZuK3BzVkc5dnZaeEMxbE96dkJIVTZxWHlHTWJhbE1SL2EwOVQwN2tUVHgr?= =?utf-8?B?QnNTTzNseExFUWFMS05iSVNNNHVNSDNhd0ZjcFB2aTc0Zk05MGgzMHlXb3Yr?= =?utf-8?B?MzR5UWI3WHc3U3NtNUtxOUttSXRtYXJIOFVMSVlOeVlCVkhEbXphK1Q1Q0Fq?= =?utf-8?B?UmQ0NUhBUXkzb1h1RkFLNUVLa1NVOGQybnJIdW8raUo4cWlvQ3hVeE56TnRH?= =?utf-8?B?RnZOZUdhWllKYXVZblZIUW9Fa281dFhvTXprTlB2N2FnVFprWTFVaFpHd2x5?= =?utf-8?B?OG5mMG1GS1Z6SklPZGMydDVTVzhQT3BPTmI2QXkveEV6K1BiU2N1dkZGbEh0?= =?utf-8?B?Snh1bGZlVGplL0lrNHp4T3lLQnFNbjczeE5qUmErcmhlYkdtRmRkbTBpMmgy?= =?utf-8?B?RUtialNqZWovSTI0Z29HOWs1WHpJWDlMbVZKalNBTUVadUtrT1pmSEpidE5v?= =?utf-8?B?RzhNcEFvQ3pIZVJETFMrRU5kZURFTnhONzBWYUJMMTV0OEJGVVpTMzZJNjgv?= =?utf-8?B?eHNiRGJkRDIrYUs5UTBpOGcxZFE3QWJqVkJCZWF3WHhxbjZqcmRyeUtxRDQx?= =?utf-8?B?VFovRkFsNG8vNjhZOEd5blN2QTJsdEtldWxOWTVUWnBUMGdYUXRCd0lYbHcr?= =?utf-8?B?dThLK1FBL3Fkd2tFNW1LSGxiV2s5Z3oyS2pPQnJuczUwT0Z5RFJreGxlVDJT?= =?utf-8?B?U1c0L2MyTTIxZDRVTWprNjRiMG5EcUFyOEtpZUgrSS8wbitjRlMxaU1tSHNX?= =?utf-8?B?S2htcG95L0x6cHhtV3NaOGI3UXc1dHA4NjdyUkpqYnJZU0pYN09kOHUvYnNh?= =?utf-8?B?K3prdmFpNEFYRm16SFRMUHd5QW5WbzJwYTY3RFYzL3ZoKzNuZ1BQT2xLNE12?= =?utf-8?B?TzlPL2x1bGk4ckxsQzFOTExtZG9JQ0N0bjhKdkpNelNtYW9FYm5Qb1pXNkN6?= =?utf-8?Q?kb06P6CoevzQmqoj/Aedl1GS9?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c09e026-7c35-4e65-b9ce-08db6786df45 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 18:41:57.4410 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LvbSu1eF9VoiuP2PP36HWRndbZlqIaIFu+RprGbm+eeuQpCv2vgnL8ebbSLY7jQX X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8302 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/12/2023 12:57 PM, Ferruh Yigit wrote: > On 5/8/2023 12:47 PM, Denis Pryazhennikov wrote: >> The documentation for the FEC API is currently incomplete and contains >> inaccuracies in its descriptions of function parameters. >> Specifically, the semantics of the fec_capa parameter in rte_eth_fec_set() >> is not well-defined. It does not provide information on what should >> be done if only AUTO bit is set or one of the specified FEC modes is >> not supported. Additionally, the fec_capa parameter in rte_eth_fec_get() >> implies that more than one FEC mode can be obtained, but it is >> wrong. Furthermore, the behaviour is undefined in >> rte_eth_fec_set() when the fec_capa parameter is zero. >> >> To address these issues, a patch series has been created that updates >> the FEC API documentation, renames one of the parameters to improve >> its clarity and adds a check for zero fec_capability. >> >> v2: >> * Update documentation for rte_eth_fec_set() to fix review comments. >> * Don't rename the fec_capa parameter of rte_eth_fec_get() but >> add a proper description instead. >> >> Denis Pryazhennikov (3): >> ethdev: update documentation for API to set FEC >> ethdev: check that at least one FEC mode is specified >> ethdev: update documentation for API to get FEC >> > > For series, > Acked-by: Ferruh Yigit > > > +cc Author and reviewer of original patch, if there is no objection I > can proceed with the set. > > > @Denis, can you please provide Fixes tags too? If you prefer you can > send a new version with ack and fixes tags. > @Denis, just a reminder that this patch is waiting for a new version.