From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 03BF61BB1E for ; Thu, 26 Oct 2017 23:09:52 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 953F220B96; Thu, 26 Oct 2017 17:09:52 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 26 Oct 2017 17:09:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=s6u6teCKSvKUwtppfd3AtBfPnA IpdKMTLCRQQrK2veQ=; b=YBVrc47k9nSMSOx2OmsOcWvF6EdyUs4pPFRxuEZo47 oALFlM2bDhXUDyVRX/CQUrv2zRAjAkv0tW9uUqqXJC2rYcrRP5ufpRGBjFT/b/8V zjR/Tie9/0Iq5vU4y9nwvkNG9u3leB97ZvKkcc4xSXziX6pIB/hU5j7QW8LrGgq7 k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=s6u6te CKSvKUwtppfd3AtBfPnAIpdKMTLCRQQrK2veQ=; b=k9emlt7MJG00TsrVUw9gTZ PKd/UWbfwlmbHTG3A1O/eGAB+6vk99E690pWHxVGiMZPUOF8ScU7QI8Sci2LUx4F PIQFCNDgK1OVupLiIU5nYgxbIaq5YmwSb0GJeiswyySbGj947w919DSFn3tEeM5j tZlVZQ6uPQOKczEyFxSKeOrbSV3TwvIBDiCr7GuI1vunUdKxluxlfIa5gHjes/f6 jxyK+pC6zS29r2AnoO8HTudyPu0y/pi+aUIbQ8CKrXcHcDnVcmoTOvIf9emrZGFD yyvae5znTLcwo2RL8lQuOqLg+I9f0qsRbvRPLXDE3RhAt39xvVsTvKXlrlhMtjEA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4343A7E13B; Thu, 26 Oct 2017 17:09:52 -0400 (EDT) From: Thomas Monjalon To: "Gonzalez Monroy, Sergio" Cc: dev@dpdk.org, Ferruh Yigit Date: Thu, 26 Oct 2017 23:09:51 +0200 Message-ID: <14385227.iJrz8hiYyE@xps> In-Reply-To: <7f85550c-f992-16eb-2e41-9aae1e6813b2@intel.com> References: <20171025083645.45740-1-ferruh.yigit@intel.com> <7f85550c-f992-16eb-2e41-9aae1e6813b2@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: fix build with glibc < 2.12 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 21:09:53 -0000 26/10/2017 16:05, Gonzalez Monroy, Sergio: > On 25/10/2017 09:36, Ferruh Yigit wrote: > > build error: > > CC rte_cycles.o > > cc1: warnings being treated as errors > > ...dpdk/lib/librte_eal/common/arch/x86/rte_cycles.c: In function > > =E2=80=98rdmsr=E2=80=99: > > ...dpdk/lib/librte_eal/common/arch/x86/rte_cycles.c:67:2: error: > > implicit declaration of function =E2=80=98pread=E2=80=99 > > ...dpdk/lib/librte_eal/common/arch/x86/rte_cycles.c:67:2: error: > > nested extern declaration of =E2=80=98pread=E2=80=99 > > > > from pread man page: > > pread(), pwrite(): > > _XOPEN_SOURCE >=3D 500 > > || /* Since glibc 2.12: */ _POSIX_C_SOURCE >=3D 200809L > > > > For glibc < 2.12 _XOPEN_SOURCE >=3D 500 is required. > > > > Adding _GNU_SOURCE define to the file which implies _XOPEN_SOURCE=3D700 > > > > Fixes: ad3516bb4ae1 ("eal/x86: implement arch-specific TSC freq query") > > Cc: sergio.gonzalez.monroy@intel.com > > > > Signed-off-by: Ferruh Yigit >=20 > Acked-by: Sergio Gonzalez Monroy Applied, thanks