DPDK patches and discussions
 help / color / mirror / Atom feed
From: chixiaobo <xiaobo.chi@nokia.com>
To: dev@dpdk.org
Cc: chixiaobo <xiaobo.chi@nokia.com>
Subject: [dpdk-dev] [PATCH] array malloced by backtrace_symbols() should be freed by the caller
Date: Tue,  4 Aug 2015 17:04:18 +0800	[thread overview]
Message-ID: <1438679058-18324-1-git-send-email-xiaobo.chi@nokia.com> (raw)

As to  linux man page: http://linux.die.net/man/3/backtrace_symbols, The address of the array of string pointers is returned as the function result of backtrace_symbols(). This array is malloced by backtrace_symbols(), and must be freed by the caller. The strings pointed to by the array of pointers need not and should not be freed.

Signed-off-by: chixiaobo <xiaobo.chi@nokia.com>
---
 lib/librte_eal/bsdapp/eal/eal_debug.c   | 3 +++
 lib/librte_eal/linuxapp/eal/eal_debug.c | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/lib/librte_eal/bsdapp/eal/eal_debug.c b/lib/librte_eal/bsdapp/eal/eal_debug.c
index 44fc4f3..ceca2e8 100644
--- a/lib/librte_eal/bsdapp/eal/eal_debug.c
+++ b/lib/librte_eal/bsdapp/eal/eal_debug.c
@@ -58,6 +58,9 @@ void rte_dump_stack(void)
 			"%d: [%s]\n", size, symb[size - 1]);
 		size --;
 	}
+	/* This array is malloced by backtrace_symbols(), and must be freed by the caller */
+	if( symb )
+		free( (void *)symb );
 }
 
 /* not implemented in this environment */
diff --git a/lib/librte_eal/linuxapp/eal/eal_debug.c b/lib/librte_eal/linuxapp/eal/eal_debug.c
index 44fc4f3..ceca2e8 100644
--- a/lib/librte_eal/linuxapp/eal/eal_debug.c
+++ b/lib/librte_eal/linuxapp/eal/eal_debug.c
@@ -58,6 +58,9 @@ void rte_dump_stack(void)
 			"%d: [%s]\n", size, symb[size - 1]);
 		size --;
 	}
+	/* This array is malloced by backtrace_symbols(), and must be freed by the caller */
+	if( symb )
+		free( (void *)symb );
 }
 
 /* not implemented in this environment */
-- 
1.9.4.msysgit.2

             reply	other threads:[~2015-08-04  9:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-04  9:04 chixiaobo [this message]
2015-08-04 16:12 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438679058-18324-1-git-send-email-xiaobo.chi@nokia.com \
    --to=xiaobo.chi@nokia.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).