DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] examples/vm_power_mgr: show warning when using systems with more than 64 cores
Date: Thu,  6 Aug 2015 12:07:41 +0100	[thread overview]
Message-ID: <1438859262-16655-2-git-send-email-pablo.de.lara.guarch@intel.com> (raw)
In-Reply-To: <1438859262-16655-1-git-send-email-pablo.de.lara.guarch@intel.com>

When using VM power manager app on systems with more than 64 cores,
app could not run even though user does not use cores 64 or higher.
The problem happens only in that case, in which case it will result
in an undefined behaviour.

Thefere, this patch allows the user to run the app on a system with more
than 64 cores, warning the user not to use cores higher than 64 in the VM(s).

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 examples/vm_power_manager/channel_manager.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c
index 7d892e2..35ff40a 100644
--- a/examples/vm_power_manager/channel_manager.c
+++ b/examples/vm_power_manager/channel_manager.c
@@ -764,12 +764,11 @@ channel_manager_init(const char *path)
 	}
 	global_n_host_cpus = (unsigned)n_cpus;
 
-	if (global_n_host_cpus > CHANNEL_CMDS_MAX_CPUS) {
-		RTE_LOG(ERR, CHANNEL_MANAGER, "The number of host CPUs(%u) exceeds the "
-				"maximum of %u\n", global_n_host_cpus, CHANNEL_CMDS_MAX_CPUS);
-		goto error;
-
-	}
+	if (global_n_host_cpus > CHANNEL_CMDS_MAX_CPUS)
+		RTE_LOG(WARNING, CHANNEL_MANAGER, "The number of host CPUs(%u) exceeds the "
+				"maximum of %u. No cores over %u should be used.\n",
+				global_n_host_cpus, CHANNEL_CMDS_MAX_CPUS,
+				CHANNEL_CMDS_MAX_CPUS - 1);
 
 	return 0;
 error:
-- 
2.4.2

  reply	other threads:[~2015-08-06 11:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-06 11:07 [dpdk-dev] [PATCH 0/2] Warn user if system has more than 64 cores when using VM power manager Pablo de Lara
2015-08-06 11:07 ` Pablo de Lara [this message]
2015-08-06 11:07 ` [dpdk-dev] [PATCH 2/2] doc: add known issue regarding VM power mgr in release notes Pablo de Lara
2015-08-07  8:03 ` [dpdk-dev] [PATCH 0/2] Warn user if system has more than 64 cores when using VM power manager Liu, Yong
2015-08-07 10:06 ` Gonzalez Monroy, Sergio
2015-08-10 21:04   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438859262-16655-2-git-send-email-pablo.de.lara.guarch@intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).