DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com, ferruh.yigit@intel.com,
	geoffrey.lv@gmail.com, ajit.khaparde@broadcom.com,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix unexpected resource mapping override
Date: Wed, 26 Sep 2018 15:50:47 +0200	[thread overview]
Message-ID: <14389377.uLlNGEYteW@xps> (raw)
In-Reply-To: <20180903084005.29706-1-qi.z.zhang@intel.com>

Hi,

03/09/2018 10:40, Qi Zhang:
> When scanning an already plugged device, the virtual address
> of mapped PCI resource in rte_pci_device will be overridden
> with 0, that may cause driver does not work correctly.

Why is it overridden with 0?
Can we try to fix the root cause?

> The fix is not to update any rte_pci_device's field if the being
> scanned device's driver is already probed.

I am going to send a patch to have a safer way of checking
whether a device is probed or not.
If this change is really needed, I suggest to rebase it on top my patch.

  reply	other threads:[~2018-09-26 13:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03  8:40 Qi Zhang
2018-09-26 13:50 ` Thomas Monjalon [this message]
2018-09-29  6:43   ` Zhang, Qi Z
2018-09-30  8:52     ` Thomas Monjalon
2018-10-03 13:03       ` Zhang, Qi Z
2018-10-30 15:27 ` [dpdk-dev] [PATCH v3] " Qi Zhang
2018-10-31 18:30   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14389377.uLlNGEYteW@xps \
    --to=thomas@monjalon.net \
    --cc=ajit.khaparde@broadcom.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=geoffrey.lv@gmail.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).