DPDK patches and discussions
 help / color / mirror / Atom feed
From: Sergey Balabanov <balabanovsv@ecotelecom.ru>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2] bonding: 8023ad: fix incorrect typecast of socket
Date: Fri,  7 Aug 2015 12:33:18 +0300	[thread overview]
Message-ID: <1438939998-30041-1-git-send-email-balabanovsv@ecotelecom.ru> (raw)
In-Reply-To: <bonding: 8023ad: fix incorrect typecast of socket>

On slave activation in LACP (8023AD) SOCKET_ANY_ID (which is -1)
is being casted to unsigned char and then to signed int.
The result is that socket_id has value of 255, not -1.
This results to memory allocation failure.

Signed-off-by: Sergey Balabanov <balabanovsv@ecotelecom.ru>
---
 drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index 97a828e..c0f0b99 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -849,7 +849,7 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, uint8_t slave_id)
 	};
 
 	char mem_name[RTE_ETH_NAME_MAX_LEN];
-	uint8_t socket_id;
+	int socket_id;
 	unsigned element_size;
 
 	/* Given slave mus not be in active list */
-- 
2.1.4

       reply	other threads:[~2015-08-07  9:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bonding: 8023ad: fix incorrect typecast of socket>
2015-08-07  9:33 ` Sergey Balabanov [this message]
2015-08-07  9:38   ` De Lara Guarch, Pablo
2015-08-09 23:55     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438939998-30041-1-git-send-email-balabanovsv@ecotelecom.ru \
    --to=balabanovsv@ecotelecom.ru \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).