From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.ecotelecom.ru (mail.ecotelecom.ru [193.105.59.24]) by dpdk.org (Postfix) with ESMTP id 7798F255 for ; Fri, 7 Aug 2015 11:33:23 +0200 (CEST) Received: from stand.ecotelecom.ru (unknown [10.210.0.221]) by mail.ecotelecom.ru (Postfix) with ESMTP id 3E81AD407AC; Fri, 7 Aug 2015 12:33:23 +0300 (MSK) From: Sergey Balabanov To: dev@dpdk.org Date: Fri, 7 Aug 2015 12:33:18 +0300 Message-Id: <1438939998-30041-1-git-send-email-balabanovsv@ecotelecom.ru> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v2] bonding: 8023ad: fix incorrect typecast of socket X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2015 09:33:23 -0000 On slave activation in LACP (8023AD) SOCKET_ANY_ID (which is -1) is being casted to unsigned char and then to signed int. The result is that socket_id has value of 255, not -1. This results to memory allocation failure. Signed-off-by: Sergey Balabanov --- drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index 97a828e..c0f0b99 100644 --- a/drivers/net/bonding/rte_eth_bond_8023ad.c +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c @@ -849,7 +849,7 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, uint8_t slave_id) }; char mem_name[RTE_ETH_NAME_MAX_LEN]; - uint8_t socket_id; + int socket_id; unsigned element_size; /* Given slave mus not be in active list */ -- 2.1.4