From: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/1] test_table: fixed failing unit tests checking offset
Date: Wed, 12 Aug 2015 14:41:27 +0200 [thread overview]
Message-ID: <1439383287-28447-2-git-send-email-maciejx.t.gajdzica@intel.com> (raw)
In-Reply-To: <1439383287-28447-1-git-send-email-maciejx.t.gajdzica@intel.com>
In commit: 1129992baa61d72c5 checking for offset alignment was removed.
Unit tests wasn't updated to reflect that change. This patch changes
checks with unaligned offsets to make tests pass.
Signed-off-by: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
---
app/test/test_table_tables.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/app/test/test_table_tables.c b/app/test/test_table_tables.c
index 14add77..88bebf8 100644
--- a/app/test/test_table_tables.c
+++ b/app/test/test_table_tables.c
@@ -226,7 +226,7 @@ test_table_array(void)
array_params.offset = 1;
table = rte_table_array_ops.f_create(&array_params, 0, 1);
- if (table != NULL)
+ if (table == NULL)
return -4;
array_params.offset = 32;
@@ -652,14 +652,14 @@ test_table_hash_lru_generic(struct rte_table_ops *ops)
hash_params.signature_offset = 1;
table = ops->f_create(&hash_params, 0, 1);
- if (table != NULL)
+ if (table == NULL)
return -2;
hash_params.signature_offset = 0;
hash_params.key_offset = 1;
table = ops->f_create(&hash_params, 0, 1);
- if (table != NULL)
+ if (table == NULL)
return -3;
hash_params.key_offset = 32;
@@ -765,14 +765,14 @@ test_table_hash_ext_generic(struct rte_table_ops *ops)
hash_params.n_entries_ext = 1 << 4;
hash_params.signature_offset = 1;
table = ops->f_create(&hash_params, 0, 1);
- if (table != NULL)
+ if (table == NULL)
return -2;
hash_params.signature_offset = 0;
hash_params.key_offset = 1;
table = ops->f_create(&hash_params, 0, 1);
- if (table != NULL)
+ if (table == NULL)
return -3;
hash_params.key_offset = 32;
--
1.7.9.5
next prev parent reply other threads:[~2015-08-12 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 12:41 [dpdk-dev] [PATCH 1/1] test_table: added ACL table test to the list Maciej Gajdzica
2015-08-12 12:41 ` Maciej Gajdzica [this message]
2015-08-13 10:50 ` [dpdk-dev] [PATCH 1/1] test_table: fixed failing unit tests checking offset Mrzyglod, DanielX T
2015-08-17 16:04 ` Thomas Monjalon
2015-08-12 12:52 ` [dpdk-dev] [PATCH 1/1] test_table: added ACL table test to the list Thomas Monjalon
2015-08-12 12:58 ` Gajdzica, MaciejX T
2015-08-13 10:25 ` Gajdzica, MaciejX T
2015-08-17 14:12 ` Gajdzica, MaciejX T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439383287-28447-2-git-send-email-maciejx.t.gajdzica@intel.com \
--to=maciejx.t.gajdzica@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).