From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 49B3E8D99 for ; Thu, 13 Aug 2015 20:06:57 +0200 (CEST) Received: by wijp15 with SMTP id p15so268133513wij.0 for ; Thu, 13 Aug 2015 11:06:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=NP3JIK3K3ehsiq++3I6dS9uvqJa3SoLTociyGWqvCbU=; b=Y6c36jnYNQr1HxMQRnd2b65nmgqvRep2GLxEfl1Z+xf+EuRpYFBiJ/MARjCQHE8vDl 7SCf/OuqlS7foKBjg78uzEGxhxpISTaecrIowgNWL17kME7KqWy/B7MOehVIFa6pj2dg WAotU3UG1WroBdx0Jdr7z/Huk97wOzklS7f1XCXaxYa75XaKmQ9R1mLee6McO2LN0nsm SSdsbGouwo8oO4h+eIxHunR+gcOmCfHZuyV6q073lyI10WcHGQzUtrz44K6Z9sR26dBw Fveev46xgGEX8/y423yVFZfHxPhQz4aq8fVN0CM/btCIJKgFr8/DeQQ6NtEAJPp0RAKO gIEg== X-Gm-Message-State: ALoCoQmBCP+TbyXOOeD2Kae0RjqX4mwMa3f8cWw8oYfBDCuLhvjbysqqOivvLZGg9S7KZn+vXr03 X-Received: by 10.180.87.71 with SMTP id v7mr54639152wiz.74.1439489216833; Thu, 13 Aug 2015 11:06:56 -0700 (PDT) Received: from vladz-laptop.localdomain (bzq-109-64-112-195.red.bezeqint.net. [109.64.112.195]) by smtp.gmail.com with ESMTPSA id ik8sm2788966wjb.8.2015.08.13.11.06.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Aug 2015 11:06:55 -0700 (PDT) From: Vlad Zolotarov To: dev@dpdk.org Date: Thu, 13 Aug 2015 21:06:35 +0300 Message-Id: <1439489195-31553-1-git-send-email-vladz@cloudius-systems.com> X-Mailer: git-send-email 2.1.0 Subject: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2015 18:06:57 -0000 According to 82599 and x540 HW specifications RS bit *must* be set in the last descriptor of *every* packet. This patch fixes the Tx hang we were constantly hitting with a seastar-based application on x540 NIC. Signed-off-by: Vlad Zolotarov --- drivers/net/ixgbe/ixgbe_ethdev.c | 9 +++++++++ drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++++++++++++++++++++++- 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index b8ee1e9..6714fd9 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -2414,6 +2414,15 @@ ixgbe_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) .txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS | ETH_TXQ_FLAGS_NOOFFLOADS, }; + + /* + * According to 82599 and x540 specifications RS bit *must* be set on the + * last descriptor of *every* packet. Therefore we will not allow the + * tx_rs_thresh above 1 for all NICs newer than 82598. + */ + if (hw->mac.type > ixgbe_mac_82598EB) + dev_info->default_txconf.tx_rs_thresh = 1; + dev_info->hash_key_size = IXGBE_HKEY_MAX_INDEX * sizeof(uint32_t); dev_info->reta_size = ETH_RSS_RETA_SIZE_128; dev_info->flow_type_rss_offloads = IXGBE_RSS_OFFLOAD_ALL; diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index 91023b9..8dbdffc 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -2085,11 +2085,19 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, struct ixgbe_tx_queue *txq; struct ixgbe_hw *hw; uint16_t tx_rs_thresh, tx_free_thresh; + bool rs_deferring_allowed; PMD_INIT_FUNC_TRACE(); hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); /* + * According to 82599 and x540 specifications RS bit *must* be set on the + * last descriptor of *every* packet. Therefore we will not allow the + * tx_rs_thresh above 1 for all NICs newer than 82598. + */ + rs_deferring_allowed = (hw->mac.type <= ixgbe_mac_82598EB); + + /* * Validate number of transmit descriptors. * It must not exceed hardware maximum, and must be multiple * of IXGBE_ALIGN. @@ -2110,6 +2118,8 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, * to transmit a packet is greater than the number of free TX * descriptors. * The following constraints must be satisfied: + * tx_rs_thresh must be less than 2 for NICs for which RS deferring is + * forbidden (all but 82598). * tx_rs_thresh must be greater than 0. * tx_rs_thresh must be less than the size of the ring minus 2. * tx_rs_thresh must be less than or equal to tx_free_thresh. @@ -2121,9 +2131,20 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, * When set to zero use default values. */ tx_rs_thresh = (uint16_t)((tx_conf->tx_rs_thresh) ? - tx_conf->tx_rs_thresh : DEFAULT_TX_RS_THRESH); + tx_conf->tx_rs_thresh : + (rs_deferring_allowed ? DEFAULT_TX_RS_THRESH : 1)); tx_free_thresh = (uint16_t)((tx_conf->tx_free_thresh) ? tx_conf->tx_free_thresh : DEFAULT_TX_FREE_THRESH); + + if (!rs_deferring_allowed && tx_rs_thresh > 1) { + PMD_INIT_LOG(ERR, "tx_rs_thresh must be less than 2 since RS " + "must be set for every packet for this HW. " + "(tx_rs_thresh=%u port=%d queue=%d)", + (unsigned int)tx_rs_thresh, + (int)dev->data->port_id, (int)queue_idx); + return -(EINVAL); + } + if (tx_rs_thresh >= (nb_desc - 2)) { PMD_INIT_LOG(ERR, "tx_rs_thresh must be less than the number " "of TX descriptors minus 2. (tx_rs_thresh=%u " -- 2.1.0