DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] mempool: fix incompatibility with C++ in header file
@ 2015-08-14  8:33 Avi Kivity
       [not found] ` <55D19C6F.3040501@6wind.com>
  0 siblings, 1 reply; 2+ messages in thread
From: Avi Kivity @ 2015-08-14  8:33 UTC (permalink / raw)
  To: dev

C++ doesn't allow implied casting from void * to another pointer, so
supply an explicit cast.

Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
---
 lib/librte_mempool/rte_mempool.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index 075bcdf..8abeca9 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -268,7 +268,7 @@ struct rte_mempool {
 /* return the header of a mempool object (internal) */
 static inline struct rte_mempool_objhdr *__mempool_get_header(void *obj)
 {
-	return RTE_PTR_SUB(obj, sizeof(struct rte_mempool_objhdr));
+	return (struct rte_mempool_objhdr *)RTE_PTR_SUB(obj, sizeof(struct rte_mempool_objhdr));
 }
 
 /**
@@ -290,7 +290,7 @@ static inline struct rte_mempool *rte_mempool_from_obj(void *obj)
 static inline struct rte_mempool_objtlr *__mempool_get_trailer(void *obj)
 {
 	struct rte_mempool *mp = rte_mempool_from_obj(obj);
-	return RTE_PTR_ADD(obj, mp->elt_size);
+	return (struct rte_mempool_objtlr *)RTE_PTR_ADD(obj, mp->elt_size);
 }
 
 /**
-- 
2.4.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] mempool: fix incompatibility with C++ in header file
       [not found] ` <55D19C6F.3040501@6wind.com>
@ 2015-08-17  8:40   ` Avi Kivity
  0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2015-08-17  8:40 UTC (permalink / raw)
  To: Olivier MATZ, thomas.monjalon; +Cc: <dev@dpdk.org>

(adding list+Thomas back to cc)

On 08/17/2015 11:33 AM, Olivier MATZ wrote:
> Hi,
>
> On 08/14/2015 10:33 AM, Avi Kivity wrote:
>> C++ doesn't allow implied casting from void * to another pointer, so
>> supply an explicit cast.
>>
>> Signed-off-by: Avi Kivity <avi@cloudius-systems.com>
> For Thomas:
> This fix is already submitted in
> http://dpdk.org/dev/patchwork/patch/6750/
>
>
> Thanks Avi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-17  8:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-14  8:33 [dpdk-dev] [PATCH] mempool: fix incompatibility with C++ in header file Avi Kivity
     [not found] ` <55D19C6F.3040501@6wind.com>
2015-08-17  8:40   ` Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).