From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5152A44136;
	Mon,  3 Jun 2024 11:11:30 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D4693402CF;
	Mon,  3 Jun 2024 11:11:29 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id 9BC6A402B7
 for <dev@dpdk.org>; Mon,  3 Jun 2024 11:11:28 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4ECB41042;
 Mon,  3 Jun 2024 02:11:52 -0700 (PDT)
Received: from [192.168.50.86] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id
 D958C3F762; Mon,  3 Jun 2024 02:11:26 -0700 (PDT)
Message-ID: <143be2a8-7c5c-469c-9f66-47b78488a52e@arm.com>
Date: Mon, 3 Jun 2024 10:11:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 4/5] dts: add `show port info` command to TestPmdShell
Content-Language: en-GB
To: Jeremy Spewock <jspewock@iol.unh.edu>
Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>, 
 Paul Szczepanek <paul.szczepanek@arm.com>
References: <20240412111136.3470304-1-luca.vizzarro@arm.com>
 <20240509112635.1170557-1-luca.vizzarro@arm.com>
 <20240509112635.1170557-5-luca.vizzarro@arm.com>
 <CAAA20URtSF7xQg_1DfU6Sf54v5sbPficdb0OD3iHsD1mGp9+kw@mail.gmail.com>
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
In-Reply-To: <CAAA20URtSF7xQg_1DfU6Sf54v5sbPficdb0OD3iHsD1mGp9+kw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 31/05/2024 22:06, Jeremy Spewock wrote:
> <snip>
>> +class DeviceCapabilitiesFlag(Flag):
>> +    """Flag representing the device capabilities."""
>> +
>> +    RUNTIME_RX_QUEUE_SETUP = auto()
>> +    """Device supports Rx queue setup after device started."""
>> +    RUNTIME_TX_QUEUE_SETUP = auto()
>> +    """Device supports Tx queue setup after device started."""
>> +    RXQ_SHARE = auto()
>> +    """Device supports shared Rx queue among ports within Rx domain and switch domain."""
>> +    FLOW_RULE_KEEP = auto()
>> +    """Device supports keeping flow rules across restart."""
>> +    FLOW_SHARED_OBJECT_KEEP = auto()
>> +    """Device supports keeping shared flow objects across restart."""
>> +
> 
> In the other flag classes it looks like these doc-strings were changed
> to be in the class var format (`#:`), but these might have been missed
> when going through and changing the others.

Argh! Yes! Will get to it