From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0DEEEA0C40;
	Fri, 30 Jul 2021 18:18:41 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8A5E240040;
	Fri, 30 Jul 2021 18:18:40 +0200 (CEST)
Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com
 [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id 52C5B4003F;
 Fri, 30 Jul 2021 18:18:39 +0200 (CEST)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.46])
 by mailnew.nyi.internal (Postfix) with ESMTP id B2ADF580A89;
 Fri, 30 Jul 2021 12:18:37 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute6.internal (MEProxy); Fri, 30 Jul 2021 12:18:37 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm1; bh=
 BiksHq4WWwXgb7a35he6dRjV5tsQjy5DpIo+/BeGBG8=; b=AByj4bhHBVPJzslE
 Usv3yMAwx9uiYyLQ29eY9B3UvXdrh9DfGg7WmjHm+1ObAu410ZfE0bFviEUA7MyG
 1quFCvzCnqxaLvZ9EJBvsd/IU6uDEOpSN6kC0sSk+XpUpv475p1PjR0BtPqqEke2
 p+QrOdqZFyr+zo7dJ/Ui4+LqBsDAj6q3ISvtNKXsOCFuXenbCNp6RweOZTjfEFst
 /Xwo8U8GyFb9ZuNIVIvTnVh+d7GrfLPjZsJydzTHZ2WMqEloJUDOn3GZ8cRPK8N8
 +ijiZhPbA690sgpz709wRxBZwXcYnwCs6pbyix6QVxthpOtHVSxQisMkLK6NxV5U
 AivCVg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm3; bh=BiksHq4WWwXgb7a35he6dRjV5tsQjy5DpIo+/BeGB
 G8=; b=ilzc4xOK5FNA/TgmWpcemJ1e+teEyAP15JsbJSOTilChhmFlQNlhv6qxk
 mo03GHTelKcXpeeBN2sBChTP9RYQVrMAEB5L2WaDKzJLXRDjpKJKvdhjNHpH5bib
 Mwxe0Gf7voxrzQ8qJgXu5YG/ObfmjeGjBdmEB4JMzXoJxbAVLVZzbt0/3o9v/edG
 7KJKWYRO7qQDtVSFXfSbp8meko29D2XU90y88OtAH3Q6r7+xXadjQ8BeGVzI73c9
 uYsMMk1P4OiTgI9wkRShQZI6UMqP6jqHZV+KW+Os4a/9r0y75dZwvB8sH1O8CfHL
 oPYwiA4+HQG4TniBXUkYLLwBh3Ljw==
X-ME-Sender: <xms:XSYEYZY3Wlbf6dYpaZe2lSqXDiEHUfbxSZd0NiThE0snhKxpM8rOsg>
 <xme:XSYEYQaLmGxBz3WO9Cb8P10l_eAPGfP5AAvY2ZI_CPmSa-lRm4zN7X_7Q-G8cUG1Y
 oDSWur3ZSopbHGktg>
X-ME-Received: <xmr:XSYEYb_twp4yIgC5g6ZgkZHjMQSTt_ihgh-qnoTl2QzhY4Cln9BZGvRvTee_DffKj5Bx174FF8RONOD7-eUW7U8qtA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrheehgdelvdcutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
 ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
 frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei
 iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh
 hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:XSYEYXpAkM0nUXwNmje0jaqlGD0ntrGSbF1jbRlfF9NQzrILlDCOMA>
 <xmx:XSYEYUrUFJlMtQfRTRafjnW_ToEXAwY91C_hY_rsPP1ec4hzuM7c0A>
 <xmx:XSYEYdR7t0XgDyx0SsCk2lG_e4BJaOeQBZijGY7fE8VdqR-mAvoRJg>
 <xmx:XSYEYagJmBsz3nmUo8ySfVNVoOGiymaVVoW0bJFWC6olLkl0ooG30A>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 30 Jul 2021 12:18:35 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
Cc: dev@dpdk.org, stable@dpdk.org,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
 Xueming Li <xuemingl@nvidia.com>, Marcin Wojtas <mw@semihalf.com>,
 Michal Krawczyk <mk@semihalf.com>, Shai Brandes <shaibran@amazon.com>,
 Evgeny Schemeilin <evgenys@amazon.com>, Igor Chauskin <igorch@amazon.com>,
 Parav Pandit <parav@nvidia.com>, Stephen Hemminger <sthemmin@microsoft.com>,
 Long Li <longli@microsoft.com>
Date: Fri, 30 Jul 2021 18:18:34 +0200
Message-ID: <14406363.YTmczRCzET@thomas>
In-Reply-To: <20210728220618.1048721-1-dkozlyuk@nvidia.com>
References: <20210727102720.902969-1-dkozlyuk@nvidia.com>
 <20210728220618.1048721-1-dkozlyuk@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] bus: clarify log for
 non-NUMA-aware devices
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

29/07/2021 00:06, Dmitry Kozlyuk:
>     EAL: PCI device 0000:00:06.0 on NUMA socket -1
> -   EAL:   Invalid NUMA socket, default to 0
> +   EAL:   Device is not NUMA-aware, defaulting socket to 0
>     EAL:   probe driver: 1d0f:ec20 net_ena

The indentation in logs are wrong because they are not all
at the same log level.
If you run at a non-debug-level, you lose the first line,
so the indent becomes meaningless and confusing.

[...]
> -		AUXILIARY_LOG(INFO, "Device is not NUMA-aware, defaulting NUMA node to 0");
> +		if (rte_socket_count() > 1)
> +			AUXILIARY_LOG(INFO, "  Device is not NUMA-aware, defaulting socket to
 0");

Instead of adding an indent, I would prefer we print the device name.
And we should remove log indents in other bus drivers.