[dpdk-dev] [PATCH v2 0/3] fix build issues with librte_sched, test_red on non x86 platform

[dpdk-dev] [PATCH v2 0/3] fix build issues with librte_sched, test_red on non x86 platform

[Jerin Jacob]

This patch set enable librte_sched, app/test/test_sched and app/test/test_red
to build on non x86 platform

v1..v2  use memory barrier version rte_rdtsc() for multi arch support as
suggested by Thomas Monjalon

Jerin Jacob (3):
  sched: remove unused inclusion of tmmintrin.h
  app/test: test_sched: fix needless build dependency on
    CONFIG_RTE_ARCH_X86_64
  app/test: use memory barrier version of rte_rdtsc() eal api for multi
    arch support

 app/test/Makefile             |  2 +-
 app/test/test_red.c           | 11 +----------
 lib/librte_sched/rte_bitmap.h |  3 ---
 3 files changed, 2 insertions(+), 14 deletions(-)

-- 
2.1.0

[dpdk-dev] [PATCH 1/3] sched: remove unused inclusion of tmmintrin.h

[Jerin Jacob]

SSSE3 intrinsics not used in rte_bitmap.h

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 lib/librte_sched/rte_bitmap.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lib/librte_sched/rte_bitmap.h b/lib/librte_sched/rte_bitmap.h
index 216a344..3d911e4 100644
--- a/lib/librte_sched/rte_bitmap.h
+++ b/lib/librte_sched/rte_bitmap.h
@@ -73,9 +73,6 @@ extern "C" {
 #ifndef RTE_BITMAP_OPTIMIZATIONS
 #define RTE_BITMAP_OPTIMIZATIONS		         1
 #endif
-#if RTE_BITMAP_OPTIMIZATIONS
-#include <tmmintrin.h>
-#endif
 
 /* Slab */
 #define RTE_BITMAP_SLAB_BIT_SIZE                 64
-- 
2.1.0

[dpdk-dev] [PATCH 2/3] app/test: test_sched: fix needless build dependency on CONFIG_RTE_ARCH_X86_64

[Jerin Jacob]

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 app/test/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/Makefile b/app/test/Makefile
index e7f148f..43429b9 100644
--- a/app/test/Makefile
+++ b/app/test/Makefile
@@ -115,7 +115,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test_cmdline_lib.c
 
 ifeq ($(CONFIG_RTE_LIBRTE_SCHED),y)
 SRCS-y += test_red.c
-SRCS-$(CONFIG_RTE_ARCH_X86_64) += test_sched.c
+SRCS-y += test_sched.c
 endif
 
 SRCS-$(CONFIG_RTE_LIBRTE_METER) += test_meter.c
-- 
2.1.0

[dpdk-dev] [PATCH 3/3] app/test: use memory barrier version of rte_rdtsc() eal api for multi arch support

[Jerin Jacob]

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 app/test/test_red.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/app/test/test_red.c b/app/test/test_red.c
index 262df72..37841b3 100644
--- a/app/test/test_red.c
+++ b/app/test/test_red.c
@@ -146,16 +146,7 @@ static void rdtsc_prof_init(struct rdtsc_prof *p, const char *name)
 
 static inline void rdtsc_prof_start(struct rdtsc_prof *p)
 {
-#ifdef __PIC__
-    asm volatile (
-    "mov %%ebx, %%edi\n"
-    "cpuid\n"
-    "xchgl %%ebx, %%edi;\n"
-	: : : "%eax", "%edi", "%ecx", "%edx" );
-#else
-	asm( "cpuid" : : : "%eax", "%ebx", "%ecx", "%edx" );
-#endif
-	p->clk_start = rte_rdtsc();
+	p->clk_start = rte_rdtsc_precise();
 }
 
 static inline void rdtsc_prof_end(struct rdtsc_prof *p)
-- 
2.1.0

Re: [dpdk-dev] [PATCH v2 0/3] fix build issues with librte_sched, test_red on non x86 platform

[Thomas Monjalon]

2015-08-30 14:25, Jerin Jacob:
> This patch set enable librte_sched, app/test/test_sched and app/test/test_red
> to build on non x86 platform
> 
> v1..v2  use memory barrier version rte_rdtsc() for multi arch support as
> suggested by Thomas Monjalon
> 
> Jerin Jacob (3):
>   sched: remove unused inclusion of tmmintrin.h
>   app/test: test_sched: fix needless build dependency on
>     CONFIG_RTE_ARCH_X86_64
>   app/test: use memory barrier version of rte_rdtsc() eal api for multi
>     arch support

Applied, thanks

[dpdk-dev] [PATCH 0/3] fix build issues with librte_sched, test_red on non x86 platform

[Jerin Jacob]

This patch set enable librte_sched, app/test/test_sched and app/test/test_red
to build on non x86 platform

Jerin Jacob (3):
  sched: remove unused inclusion of tmmintrin.h
  app/test: test_sched: fix needless build dependency on
    CONFIG_RTE_ARCH_X86_64
  app/test: enable test_red to build on non x86 platform

 app/test/Makefile             | 2 +-
 app/test/test_red.c           | 2 ++
 lib/librte_sched/rte_bitmap.h | 3 ---
 3 files changed, 3 insertions(+), 4 deletions(-)

-- 
2.1.0

[dpdk-dev] [PATCH 1/3] sched: remove unused inclusion of tmmintrin.h

[Jerin Jacob]

SSSE3 intrinsics not used in rte_bitmap.h

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 lib/librte_sched/rte_bitmap.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lib/librte_sched/rte_bitmap.h b/lib/librte_sched/rte_bitmap.h
index 216a344..3d911e4 100644
--- a/lib/librte_sched/rte_bitmap.h
+++ b/lib/librte_sched/rte_bitmap.h
@@ -73,9 +73,6 @@ extern "C" {
 #ifndef RTE_BITMAP_OPTIMIZATIONS
 #define RTE_BITMAP_OPTIMIZATIONS		         1
 #endif
-#if RTE_BITMAP_OPTIMIZATIONS
-#include <tmmintrin.h>
-#endif
 
 /* Slab */
 #define RTE_BITMAP_SLAB_BIT_SIZE                 64
-- 
2.1.0