* [dpdk-dev] [PATCH] librte_cfgfile (rte_cfgfile.h): modify the macros values
@ 2015-09-02 15:53 Jasvinder Singh
2015-09-02 20:47 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Jasvinder Singh @ 2015-09-02 15:53 UTC (permalink / raw)
To: dev
This patch refers to the ABI change proposed for librte_cfgfile (rte_cfgfile.h).
In order to allow for longer names and values, the new values of macros CFG_NAME_LEN and CFG_NAME_VAL are set.
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
lib/librte_cfgfile/rte_cfgfile.h | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/lib/librte_cfgfile/rte_cfgfile.h b/lib/librte_cfgfile/rte_cfgfile.h
index 7c9fc91..d443782 100644
--- a/lib/librte_cfgfile/rte_cfgfile.h
+++ b/lib/librte_cfgfile/rte_cfgfile.h
@@ -47,8 +47,13 @@ extern "C" {
*
***/
-#define CFG_NAME_LEN 32
-#define CFG_VALUE_LEN 64
+#ifndef CFG_NAME_LEN
+#define CFG_NAME_LEN 64
+#endif
+
+#ifndef CFG_VALUE_LEN
+#define CFG_VALUE_LEN 256
+#endif
/** Configuration file */
struct rte_cfgfile;
--
2.1.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] librte_cfgfile (rte_cfgfile.h): modify the macros values
2015-09-02 15:53 [dpdk-dev] [PATCH] librte_cfgfile (rte_cfgfile.h): modify the macros values Jasvinder Singh
@ 2015-09-02 20:47 ` Thomas Monjalon
2015-09-03 9:53 ` Singh, Jasvinder
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2015-09-02 20:47 UTC (permalink / raw)
To: Jasvinder Singh; +Cc: dev
2015-09-02 16:53, Jasvinder Singh:
> This patch refers to the ABI change proposed for librte_cfgfile (rte_cfgfile.h).
> In order to allow for longer names and values, the new values of macros CFG_NAME_LEN and CFG_NAME_VAL are set.
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
> lib/librte_cfgfile/rte_cfgfile.h | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
If the ABI is changed, the LIBABIVER number must be bumped.
The release notes must also be updated and the deprecation announce
must be removed.
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] librte_cfgfile (rte_cfgfile.h): modify the macros values
2015-09-02 20:47 ` Thomas Monjalon
@ 2015-09-03 9:53 ` Singh, Jasvinder
0 siblings, 0 replies; 3+ messages in thread
From: Singh, Jasvinder @ 2015-09-03 9:53 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, September 2, 2015 9:48 PM
> To: Singh, Jasvinder
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] librte_cfgfile (rte_cfgfile.h): modify the
> macros values
>
> 2015-09-02 16:53, Jasvinder Singh:
> > This patch refers to the ABI change proposed for librte_cfgfile
> (rte_cfgfile.h).
> > In order to allow for longer names and values, the new values of macros
> CFG_NAME_LEN and CFG_NAME_VAL are set.
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > ---
> > lib/librte_cfgfile/rte_cfgfile.h | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
>
> If the ABI is changed, the LIBABIVER number must be bumped.
> The release notes must also be updated and the deprecation announce must
> be removed.
> Thanks
Thanks, Thomas. I will submit v2 patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-03 9:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-02 15:53 [dpdk-dev] [PATCH] librte_cfgfile (rte_cfgfile.h): modify the macros values Jasvinder Singh
2015-09-02 20:47 ` Thomas Monjalon
2015-09-03 9:53 ` Singh, Jasvinder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).