From: Alex Kiselev <alex@therouter.net>
To: Matan Azrad <matan@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
Chas Williams <3chas3@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v3] net/bonding: add add/remove mac addrs
Date: Wed, 20 Jun 2018 11:42:49 +0300 [thread overview]
Message-ID: <1441417307.20180620114249@therouter.net> (raw)
In-Reply-To: <VI1PR0501MB2608DAEB263266A3CE7322A6D2700@VI1PR0501MB2608.eurprd05.prod.outlook.com>
> Please see comments below.
From: Matan Azrad
>> +/*
>> + * Remove additional MAC addresses from the slave */ int
>> +slave_remove_mac_addresses(struct rte_eth_dev *bonded_eth_dev,
>> + uint16_t slave_port_id)
>> +{
>> + int i, ret = 0;
>> + struct ether_addr *mac_addr;
>> +
>> + for (i = 1; i < BOND_MAX_MAC_ADDRS; i++) {
>> + mac_addr = &bonded_eth_dev->data->mac_addrs[i];
>> + if (is_same_ether_addr(mac_addr, &null_mac_addr))
>> + break;
>> +
>> + ret = rte_eth_dev_mac_addr_remove(slave_port_id,
>> mac_addr);
>> + }
> I suggest to return the first error, also in case of all success
> with last failure, the code here wrongly returns success.
Fixed in the patch v4.
--
Alex
next prev parent reply other threads:[~2018-06-20 8:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0d1c4f28-e08b-40e7-9b9e-0d4bdd15279a@VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com>
2018-06-19 9:00 ` Matan Azrad
2018-06-19 9:19 ` Alex Kiselev
2018-06-19 10:13 ` Matan Azrad
2018-06-20 8:42 ` Alex Kiselev [this message]
2018-06-19 8:32 Alex Kiselev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441417307.20180620114249@therouter.net \
--to=alex@therouter.net \
--cc=3chas3@gmail.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).