From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alex@therouter.net>
Received: from relay-out6.mail.masterhost.ru (relay-out6.mail.masterhost.ru
 [83.222.12.16]) by dpdk.org (Postfix) with ESMTP id 5EFFE1B473
 for <dev@dpdk.org>; Wed, 20 Jun 2018 10:42:58 +0200 (CEST)
Received: from [37.139.80.50] (helo=nw)
 by relay6.mail.masterhost.ru with esmtpa 
 envelope from <alex@therouter.net>
 authenticated with alex@therouter.net
 message id 1fVYhc-0005X2-Es; Wed, 20 Jun 2018 11:42:56 +0300
Date: Wed, 20 Jun 2018 11:42:49 +0300
From: Alex Kiselev <alex@therouter.net>
Message-ID: <1441417307.20180620114249@therouter.net>
To: Matan Azrad <matan@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>, 
 Chas   Williams <3chas3@gmail.com>, 
 Stephen Hemminger <stephen@networkplumber.org>
In-Reply-To: <VI1PR0501MB2608DAEB263266A3CE7322A6D2700@VI1PR0501MB2608.eurprd05.prod.outlook.com>
References: <0d1c4f28-e08b-40e7-9b9e-0d4bdd15279a@VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com>
 <VI1PR0501MB2608DAEB263266A3CE7322A6D2700@VI1PR0501MB2608.eurprd05.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-KLMS-Rule-ID: 1
X-KLMS-Message-Action: clean
X-KLMS-AntiSpam-Lua-Profiles: 126034 [Jun 20 2018]
X-KLMS-AntiSpam-Version: 5.8.1.0
X-KLMS-AntiSpam-Envelope-From: alex@therouter.net
X-KLMS-AntiSpam-Rate: 0
X-KLMS-AntiSpam-Status: not_detected
X-KLMS-AntiSpam-Method: none
X-KLMS-AntiSpam-Info: LuaCore: 146 146
 2365bc6c38c3cc6a39a631922dcb3b077b6ed1a2, {rep_avail}, DmarcAF: none
X-MS-Exchange-Organization-SCL: -1
X-KLMS-AntiSpam-Interceptor-Info: scan successful
X-KLMS-AntiPhishing: not scanned, disabled by settings
X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.2.16,
 not scanned, license restriction
Subject: Re: [dpdk-dev] [PATCH v3] net/bonding: add add/remove mac addrs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jun 2018 08:42:58 -0000


> Please see comments below.

From: Matan Azrad
>> +/*
>> + * Remove additional MAC addresses from the slave  */ int
>> +slave_remove_mac_addresses(struct rte_eth_dev *bonded_eth_dev,
>> +             uint16_t slave_port_id)
>> +{
>> +     int i, ret = 0;
>> +     struct ether_addr *mac_addr;
>> +
>> +     for (i = 1; i < BOND_MAX_MAC_ADDRS; i++) {
>> +             mac_addr = &bonded_eth_dev->data->mac_addrs[i];
>> +             if (is_same_ether_addr(mac_addr, &null_mac_addr))
>> +                     break;
>> +
>> +             ret = rte_eth_dev_mac_addr_remove(slave_port_id,
>> mac_addr);
>> +     }

> I suggest to return the first error, also in case of all success
> with last failure, the code here wrongly returns success. 

Fixed in the patch v4.


-- 
Alex