From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id A54FCC3AC for ; Thu, 23 Jul 2015 18:18:39 +0200 (CEST) Received: by wibud3 with SMTP id ud3so932555wib.0 for ; Thu, 23 Jul 2015 09:18:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=4OJB8R4CgEkg+A3rHaEli1DHE/L/AKcla5iMLgOHhao=; b=gkgrqzqbfX+MX9HS+eEvqcHWn5nxeCPt3A5mcf3wJf6J4eiEv8NjQ+vbOpDHVb0tpj kAcNFJ3boNjmXtUwjiAt2VuE1+LLDDKkU6TCpFG+s5N11d+6fwclCXia07gInhjuvUO2 46ZuTesh7ALleZKYOQxZ/wDf8PDuYreBeBhVxCbbIjhkNNnmj4ZFwPWpmZBrV1DJeR0+ lXcPaFv1Y8cYWz36wOzY4UvrKsACRxZWpgnqIiCpFk8ipqn6Xp5Wy909RKlsOsxcy9qH tciLrWD4dST4Nc2SHVuxNOK+UZhuHPDlgL4LaMrQZoEIZT7YNhwcDOR/xEKwUZr01L35 mmfQ== X-Gm-Message-State: ALoCoQlXQ37eeYljx8MKEVW2Dey3Xnek4EhXPK53RjmfPBVz6p155n2nzxXX6ptfcLcH6RGEoO7g X-Received: by 10.180.188.176 with SMTP id gb16mr51890377wic.18.1437668319537; Thu, 23 Jul 2015 09:18:39 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id gj6sm9819796wib.22.2015.07.23.09.18.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Jul 2015 09:18:38 -0700 (PDT) From: Thomas Monjalon To: "Ananyev, Konstantin" Date: Thu, 23 Jul 2015 18:17:25 +0200 Message-ID: <1441832.QYmNKRXLMA@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB97725836A64BE0@irsmsx105.ger.corp.intel.com> References: <1437589735-30041-1-git-send-email-konstantin.ananyev@intel.com> <20150722124802.6a0f4745@urahara> <2601191342CEEE43887BDE71AB97725836A64BE0@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCHv4 1/5] ethdev: add new API to retrieve RX/TX queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2015 16:18:39 -0000 2015-07-23 10:52, Ananyev, Konstantin: > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Konstantin Ananyev wrote: > > > Add the ability for the upper layer to query RX/TX queue information. [...] > > Since all this data should be rxconf already, Is it possible > > to do a generic version of this and not have to change every driver. > > I don't think it is possible to implement these two functions at rte_etdev level only. > At least not with current ethdev/PMD implementation: > - Inside struct rte_eth_dev_info we have only: 'struct rte_eth_rxconf default_rxconf;'. > We don't have rxconf here for each configured rx queue. > That information is maintained by PMD and inside PMD, different devices have different format for queue structure. > - rte_eth_rxq_info contains not only rxconf but some extra information: mempool in use by that queue, > min/max possible number of descriptors. > Also my intention was that in future that structure would be extended to provide some RT info about queue: > (number of free/used descriptors from SW point of view, etc). Isn't it what rte_eth_rx_queue_count() provides? Maybe we should deprecate it in favor of rte_eth_rx_queue_info_get().