From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Pass verbose flag to kernel module
Date: Thu, 09 Oct 2014 14:15:40 +0200 [thread overview]
Message-ID: <1443746.oWjnEGgJIl@xps13> (raw)
In-Reply-To: <20141009093713.GB23978@sivswdev02.ir.intel.com>
Hi Sergio,
2014-10-09 10:37, Sergio Gonzalez Monroy:
> On Wed, Oct 08, 2014 at 07:05:32PM +0200, Thomas Monjalon wrote:
> > Hi Sergio,
> >
> > 2014-10-06 17:09, Sergio Gonzalez Monroy:
> > > --- a/mk/rte.module.mk
> > > +++ b/mk/rte.module.mk
> > > @@ -78,7 +78,7 @@ build: _postbuild
> > > $(MODULE).ko: $(SRCS_LINKS)
> > > @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi
> > > @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \
> > > - CROSS_COMPILE=$(CROSS)
> > > + V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS)
> >
> > Please could you explain why it is needed?
> > The variable V should be inherited by the recursive make.
> > It's working without your patch in my test.
>
> You are right. If you set V=1 in the commmand line it will inherit and pass it down.
> In the curent framework, we do not force V to be 1, just to be defined (coud be V=y
> or V=enable, etc).
> This patch was just forcing the value to be 1 as it is the required value for the
> kernel makefiles.
>
> It is not a big deal and we could approach this by specifiying on the docs to be V=1
> or any other way you think more appropiate?
Oh OK, I didn't imagine passing other value to V ;)
It's better to fix makefile than doc. So I'm OK with this patch.
--
Thomas
next prev parent reply other threads:[~2014-10-09 12:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 16:09 Sergio Gonzalez Monroy
2014-10-08 17:05 ` Thomas Monjalon
2014-10-09 9:37 ` Sergio Gonzalez Monroy
2014-10-09 12:15 ` Thomas Monjalon [this message]
2014-10-13 16:08 ` De Lara Guarch, Pablo
2014-10-15 12:04 ` Thomas Monjalon
2014-10-15 13:05 ` Gonzalez Monroy, Sergio
2014-10-15 13:08 ` [dpdk-dev] [PATCH] Set V=1 when building kernel modules Sergio Gonzalez Monroy
2014-10-15 13:43 ` Gonzalez Monroy, Sergio
2014-10-15 13:08 ` [dpdk-dev] [PATCH v2] " Sergio Gonzalez Monroy
2014-10-15 14:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443746.oWjnEGgJIl@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).