From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 3FD3B6A94 for ; Thu, 9 Oct 2014 14:08:38 +0200 (CEST) Received: by mail-wi0-f171.google.com with SMTP id em10so12864048wid.16 for ; Thu, 09 Oct 2014 05:15:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=3PW8req1grLSAYp+mSPw+ITifTYRBEcPixrkBZTYDzI=; b=fxSdPiDWQzKP8KzPyh84F7gt3zSesZ97vv3mOZ4Sy769VjG6Svs2+zPg9k+M0Ge+xt snMQH0a5BhsVawm911aqvC9523v5TjvGtuC7JHkxwGYDL65MkKQHulbPGQSG3unSh0LM 63UiXXbxiENUcgi+gkZ0dCHza+McAI8/IeJc9SNzEwvIq6+1j+lufEQjRMnZcUWOxrjp +898IB+lKQaV2AGJrz43kLRrfG1yU32TRlhhMH6zpbC970wO6G25vX4nruBBGH5uuftA xpZPwSK4Jfuc1ps2aLaj7gm4DkEH77cisAxHHjiiAs/VhbsuRB12ui680Vu08Cv7ea6y WeNA== X-Gm-Message-State: ALoCoQkgcPaEsyLYe/dUAYFNIvX/62k+c/DDwZk32rvVpk0zkTG8iag4xMKo3IDxbKs663FqWdIP X-Received: by 10.194.78.136 with SMTP id b8mr3473683wjx.106.1412856958150; Thu, 09 Oct 2014 05:15:58 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id q3sm21787857wia.14.2014.10.09.05.15.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Oct 2014 05:15:57 -0700 (PDT) From: Thomas Monjalon To: Sergio Gonzalez Monroy Date: Thu, 09 Oct 2014 14:15:40 +0200 Message-ID: <1443746.oWjnEGgJIl@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <20141009093713.GB23978@sivswdev02.ir.intel.com> References: <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1731940.NUuDDJsRCL@xps13> <20141009093713.GB23978@sivswdev02.ir.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Pass verbose flag to kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Oct 2014 12:08:38 -0000 Hi Sergio, 2014-10-09 10:37, Sergio Gonzalez Monroy: > On Wed, Oct 08, 2014 at 07:05:32PM +0200, Thomas Monjalon wrote: > > Hi Sergio, > > > > 2014-10-06 17:09, Sergio Gonzalez Monroy: > > > --- a/mk/rte.module.mk > > > +++ b/mk/rte.module.mk > > > @@ -78,7 +78,7 @@ build: _postbuild > > > $(MODULE).ko: $(SRCS_LINKS) > > > @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > > > @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ > > > - CROSS_COMPILE=$(CROSS) > > > + V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS) > > > > Please could you explain why it is needed? > > The variable V should be inherited by the recursive make. > > It's working without your patch in my test. > > You are right. If you set V=1 in the commmand line it will inherit and pass it down. > In the curent framework, we do not force V to be 1, just to be defined (coud be V=y > or V=enable, etc). > This patch was just forcing the value to be 1 as it is the required value for the > kernel makefiles. > > It is not a big deal and we could approach this by specifiying on the docs to be V=1 > or any other way you think more appropiate? Oh OK, I didn't imagine passing other value to V ;) It's better to fix makefile than doc. So I'm OK with this patch. -- Thomas