From: "Charles (Chas) Williams" <3chas3@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] devargs: add blacklisting by linux interface name
Date: Tue, 06 Oct 2015 10:41:46 -0400 [thread overview]
Message-ID: <1444142506.3494.55.camel@gmail.com> (raw)
In-Reply-To: <20151006083555.72293697@uryu.home.lan>
On Tue, 2015-10-06 at 08:35 +0100, Stephen Hemminger wrote:
> On Mon, 5 Oct 2015 11:26:08 -0400
> Chas Williams <3chas3@gmail.com> wrote:
>
> > diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h
> > index 83e3c28..852c149 100644
> > --- a/lib/librte_eal/common/include/rte_pci.h
> > +++ b/lib/librte_eal/common/include/rte_pci.h
> > @@ -161,6 +161,7 @@ struct rte_pci_device {
> > struct rte_pci_resource mem_resource[PCI_MAX_RESOURCE]; /**< PCI Memory Resource */
> > struct rte_intr_handle intr_handle; /**< Interrupt handle */
> > struct rte_pci_driver *driver; /**< Associated driver */
> > + char name[32];
>
> Why not use IFNAMSIZ rather than magic constant here?
No particular reason. It just matches the virtual device name size.
I will change it.
next prev parent reply other threads:[~2015-10-06 14:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 15:00 [dpdk-dev] [PATCH] " Chas Williams
2015-10-02 15:18 ` Bruce Richardson
2015-10-02 16:38 ` Charles (Chas) Williams
2015-10-02 16:44 ` Richardson, Bruce
2015-10-02 18:29 ` Charles (Chas) Williams
2015-10-05 15:59 ` Charles (Chas) Williams
2015-10-05 15:26 ` [dpdk-dev] [PATCH v2] " Chas Williams
2015-10-06 7:35 ` Stephen Hemminger
2015-10-06 14:41 ` Charles (Chas) Williams [this message]
2015-10-13 12:49 ` Olivier MATZ
2015-10-14 13:41 ` Charles (Chas) Williams
2015-11-04 22:40 ` Thomas Monjalon
2015-11-05 16:39 ` Charles (Chas) Williams
2015-11-05 19:23 ` Stephen Hemminger
2015-11-10 18:51 ` Charles (Chas) Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444142506.3494.55.camel@gmail.com \
--to=3chas3@gmail.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).