From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <3chas3@gmail.com>
Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com
 [209.85.220.181]) by dpdk.org (Postfix) with ESMTP id CAE685921
 for <dev@dpdk.org>; Tue,  6 Oct 2015 16:41:47 +0200 (CEST)
Received: by qkht68 with SMTP id t68so2254654qkh.3
 for <dev@dpdk.org>; Tue, 06 Oct 2015 07:41:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=message-id:subject:from:to:cc:date:in-reply-to:references
 :content-type:mime-version:content-transfer-encoding;
 bh=NdgemRrAPvYdMNrIpkf7xedSMU2WkkvYqkRo9eUNbiw=;
 b=uQ3wrmCjqxfRrGALf8v/xHIlkU83fFzpyBUL64jbu81huRjEM0CXfGnAh0N+l+qh6s
 A94cBD5yQS3DDfK6JRDm18FefiUvEFwsZSkajuZpnEfQgp9trwItX0ODvRQDzT6rZAgS
 0AKEQkOdr1kF6zErCPgt5/ECtyk3xBwBXF2jTYFagGplyc5CF2+WV/KRb1LZs8ZMK2OT
 0Ad1p0135duHPgGOAHAJlUJYV4/IBDfKKPrEA41Xe1j0BppmG/fyWVW82B+GJwBelRUA
 C5ayHDYSA4peH6W/82rWaM7pM6iLfmZiLVz66rs1iLOxcH3kjuylDNs8DQtV2ucsVsn7
 Ktnw==
X-Received: by 10.55.31.232 with SMTP id n101mr32363780qkh.107.1444142507310; 
 Tue, 06 Oct 2015 07:41:47 -0700 (PDT)
Received: from foobar.home (pool-71-163-182-126.washdc.fios.verizon.net.
 [71.163.182.126])
 by smtp.googlemail.com with ESMTPSA id m26sm8684249qki.28.2015.10.06.07.41.46
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 06 Oct 2015 07:41:46 -0700 (PDT)
Message-ID: <1444142506.3494.55.camel@gmail.com>
From: "Charles (Chas) Williams" <3chas3@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue, 06 Oct 2015 10:41:46 -0400
In-Reply-To: <20151006083555.72293697@uryu.home.lan>
References: <1443798007-20122-1-git-send-email-3chas3@gmail.com>
 <1444058768-9208-1-git-send-email-3chas3@gmail.com>
 <20151006083555.72293697@uryu.home.lan>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] devargs: add blacklisting by linux
 interface name
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Oct 2015 14:41:48 -0000

On Tue, 2015-10-06 at 08:35 +0100, Stephen Hemminger wrote:
> On Mon,  5 Oct 2015 11:26:08 -0400
> Chas Williams <3chas3@gmail.com> wrote:
> 
> > diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h
> > index 83e3c28..852c149 100644
> > --- a/lib/librte_eal/common/include/rte_pci.h
> > +++ b/lib/librte_eal/common/include/rte_pci.h
> > @@ -161,6 +161,7 @@ struct rte_pci_device {
> >  	struct rte_pci_resource mem_resource[PCI_MAX_RESOURCE];   /**< PCI Memory Resource */
> >  	struct rte_intr_handle intr_handle;     /**< Interrupt handle */
> >  	struct rte_pci_driver *driver;          /**< Associated driver */
> > +	char name[32];
> 
> Why not use IFNAMSIZ rather than magic constant here?

No particular reason.  It just matches the virtual device name size.
I will change it.