From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C356A04B6; Mon, 12 Oct 2020 21:37:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C0D281D988; Mon, 12 Oct 2020 21:37:16 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 235C31D90E for ; Mon, 12 Oct 2020 21:37:13 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 09CJZgJP032335; Mon, 12 Oct 2020 12:37:12 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pfpt0220; bh=eaG2pxLwEvrV6TPt9xfYFpk/J+an08V5DUhyk3OROLI=; b=US1HruIopHge5oSIvWYLh0Eu3BfHaQPNTVzyjAmnfSdpiKD8WQVayDDiIlU9mxzzAnSg Qb9Nb6+3/Cx+GAuvYpW3Kyr76FJxGnJHTewx65jf2yGlDhnWEBcsg946gEFO9Xy5/Ta6 W94czagAhRLGfX2lF3rBvsFxOopJjWbBevHe3o4moRJkxmFumvj4SR4kq8xv/0kX0hri lTjWJ9mNI8Rxz9f//84HKRKcpgcpeDoyeOQRt2nJv1sOxUCDhnny4xecAkQLTDNAr3Su 7z9FPEWPzZzHHi8yfR0Cf7nsYrUilYRd7p1SX2mPDQfu3SFrZU/WywUd57Q45AxhAajA 4w== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 343aanfj7m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 12 Oct 2020 12:37:12 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Oct 2020 12:37:12 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Oct 2020 12:37:11 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 12 Oct 2020 12:37:11 -0700 Received: from [10.193.39.7] (NN-LT0019.marvell.com [10.193.39.7]) by maili.marvell.com (Postfix) with ESMTP id 50DE53F703F; Mon, 12 Oct 2020 12:37:08 -0700 (PDT) To: Ferruh Yigit , CC: Rasesh Mody , Devendra Singh Rawat , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Stephen Hemminger References: <20200925090757.1338-1-irusskikh@marvell.com> From: Igor Russkikh Message-ID: <144458cd-c45b-ae5d-29b7-c24f6f449484@marvell.com> Date: Mon, 12 Oct 2020 22:37:06 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-12_17:2020-10-12, 2020-10-12 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [RFC PATCH v2] app/testpmd: tx pkt clones parameter in flowgen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >> Here instead of recreating each packet separately, we use clones counter >> to resend the same mbuf to the line multiple times. >> > Do you have any numbers on how much performance improvement gained? Hi Ferruh, Yes, I'll post that in v1. In general, on our 100G device in default configuration I had to use 8-16 queues (read cores) to reach line rate on 1400 packet size. Will give exact numbers. With clones I was able to see linerate on 1-2 tx queues. That of course depends on if HW itself allows to handle that amount of traffic. Reaching max PPS on small packet sizes obviously helps here as well. >> + rte_exit(EXIT_FAILURE, >> + "clones must be >= 0 and <= %d (burst)\n", >> + nb_pkt_per_burst); > > Do you need to enforce the "n <= nb_pkt_per_burst", burst value can be > changed > later and trying to keep 'clones' values in sync with it is additional work. > > In the flowgen logic, with each burst a new packet is created anyway. So > instead > of enforcing the 'clones' number range, in documentation you can say the > clone > number can't exceed the burst number whatever it is set. Looks reasonable, thanks. >> uint16_t nb_pkt_per_burst = DEF_PKT_BURST; /**< Number of packets per >> burst. */ >> +uint16_t nb_pkt_clones; /**< Number of tx packet clones to send. */ >> uint16_t mb_mempool_cache = DEF_MBUF_CACHE; /**< Size of mbuf mempool >> cache. */ >> > > Both the parameter name, 'clones', and the variable name 'nb_pkt_clones' are > too > generic, and may mislead users. Please remember that testpms usage is very > wide. > You are updating very specifically the flowgen forwarding engine, can you > please > prefix the 'flowgen', like: > 'flowgen-clones' & 'nb_pkt_flowgen_clones'. > Also explicitly mention in the description that this is for flowgen clones. Reasonable as well. Initially I was thinking about applying that to "tx-only" as well, but the decided to stay with flowgen as more generic mode. Thanks, Igor