From: Harry van Haaren <harry.van.haaren@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] ixgbe: fix VF statistic wraparound handling macro
Date: Mon, 12 Oct 2015 14:33:42 +0100 [thread overview]
Message-ID: <1444656823-717-2-git-send-email-harry.van.haaren@intel.com> (raw)
In-Reply-To: <1444656823-717-1-git-send-email-harry.van.haaren@intel.com>
Fix a misinterpretation of VF stats in ixgbe
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index ec2918c..d226e8d 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -329,10 +329,14 @@ static int ixgbe_timesync_read_tx_timestamp(struct rte_eth_dev *dev,
/*
* Define VF Stats MACRO for Non "cleared on read" register
*/
-#define UPDATE_VF_STAT(reg, last, cur) \
+#define UPDATE_VF_STAT(reg, last, cur) \
{ \
uint32_t latest = IXGBE_READ_REG(hw, reg); \
- cur += latest - last; \
+ if(likely(latest > last)) { \
+ cur += latest - last; \
+ } else { \
+ cur += (UINT_MAX - last) + latest; \
+ } \
last = latest; \
}
--
1.9.1
next prev parent reply other threads:[~2015-10-12 13:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 13:33 [dpdk-dev] [PATCH 0/2] fix vf statistic wraparound handling in macro Harry van Haaren
2015-10-12 13:33 ` Harry van Haaren [this message]
2015-10-12 14:45 ` [dpdk-dev] [PATCH 1/2] ixgbe: fix VF statistic wraparound handling macro Roger B. Melton
2015-10-12 15:41 ` Alexander Duyck
2015-10-12 16:45 ` [dpdk-dev] [PATCH 0/2] fix vf statistic wraparound handling in macro Harry van Haaren
2015-10-12 16:45 ` [dpdk-dev] [PATCH 1/2] ixgbe: fix VF statistic wraparound handling macro Harry van Haaren
2015-10-13 19:43 ` Roger B. Melton
2015-10-14 10:15 ` Roger B. Melton
2015-10-28 13:37 ` Thomas Monjalon
2015-10-12 16:45 ` [dpdk-dev] [PATCH 2/2] igb: " Harry van Haaren
2015-10-13 19:44 ` Roger B. Melton
2015-10-14 10:16 ` Roger B. Melton
2015-10-28 13:40 ` [dpdk-dev] [PATCH 0/2] fix vf statistic wraparound handling in macro Thomas Monjalon
2015-10-13 19:43 ` [dpdk-dev] [PATCH 1/2] ixgbe: fix VF statistic wraparound handling macro Roger B. Melton
2015-10-12 13:33 ` [dpdk-dev] [PATCH 2/2] igb: " Harry van Haaren
2015-10-12 15:02 ` Roger B. Melton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444656823-717-2-git-send-email-harry.van.haaren@intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).