DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tiwei Bie <btw@mail.ustc.edu.cn>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] eal/bsd: reinitialize optind and optreset to 1
Date: Tue, 13 Oct 2015 16:54:06 +0800	[thread overview]
Message-ID: <1444726446-8106-2-git-send-email-btw@mail.ustc.edu.cn> (raw)
In-Reply-To: <1444726446-8106-1-git-send-email-btw@mail.ustc.edu.cn>

The variable optind must be reinitialized to 1 in order to skip over
argv[0] on FreeBSD. Because getopt() on FreeBSD will return -1 when
it meets an argument which doesn't start with '-'.

The variable optreset is provided on FreeBSD to indicate the additional
set of calls to getopt(). So, also reinitialize it to 1.

Signed-off-by: Tiwei Bie <btw@mail.ustc.edu.cn>
---
 lib/librte_eal/bsdapp/eal/eal.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index 1b6f705..35feaee 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -334,7 +334,8 @@ eal_log_level_parse(int argc, char **argv)
 			break;
 	}
 
-	optind = 0; /* reset getopt lib */
+	optind = 1; /* reset getopt lib */
+	optreset = 1;
 }
 
 /* Parse the argument given in the command line of the application */
@@ -403,7 +404,8 @@ eal_parse_args(int argc, char **argv)
 	if (optind >= 0)
 		argv[optind-1] = prgname;
 	ret = optind-1;
-	optind = 0; /* reset getopt lib */
+	optind = 1; /* reset getopt lib */
+	optreset = 1;
 	return ret;
 }
 
-- 
2.6.0

  reply	other threads:[~2015-10-13  8:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13  8:54 [dpdk-dev] [PATCH] Found a bug related to getopt() in eal/bsd module Tiwei Bie
2015-10-13  8:54 ` Tiwei Bie [this message]
2015-10-13 14:58   ` [dpdk-dev] [PATCH] eal/bsd: reinitialize optind and optreset to 1 Bruce Richardson
2015-10-13 17:14   ` Don Provan
     [not found]     ` <20151014022843.GA26774@dell>
2015-10-14  9:31       ` Bruce Richardson
2015-10-14 10:19         ` Tiwei Bie
2015-10-14 11:28           ` Tiwei Bie
2015-10-14 17:54             ` Don Provan
2015-10-15  1:40               ` Tiwei Bie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444726446-8106-2-git-send-email-btw@mail.ustc.edu.cn \
    --to=btw@mail.ustc.edu.cn \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).