From: Jerome Jutteau <jerome.jutteau@outscale.com>
To: dev@dpdk.org
Cc: changchun.ouyang@intel.com
Subject: [dpdk-dev] [PATCH 3/3] vhost: protect user_get_vring_base from unknown devices
Date: Fri, 16 Oct 2015 11:08:50 +0200 [thread overview]
Message-ID: <1444986530-20893-4-git-send-email-jerome.jutteau@outscale.com> (raw)
In-Reply-To: <1444986530-20893-1-git-send-email-jerome.jutteau@outscale.com>
get_device return is not checked and may cause segfault when device is
not found. This patch fix this.
Signed-off-by: Jerome Jutteau <jerome.jutteau@outscale.com>
---
lib/librte_vhost/vhost_user/virtio-net-user.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_vhost/vhost_user/virtio-net-user.c b/lib/librte_vhost/vhost_user/virtio-net-user.c
index 4689927..e0bc2a4 100644
--- a/lib/librte_vhost/vhost_user/virtio-net-user.c
+++ b/lib/librte_vhost/vhost_user/virtio-net-user.c
@@ -276,6 +276,8 @@ user_get_vring_base(struct vhost_device_ctx ctx,
{
struct virtio_net *dev = get_device(ctx);
+ if (dev == NULL)
+ return -1;
/* We have to stop the queue (virtio) if it is running. */
if (dev->flags & VIRTIO_DEV_RUNNING)
notify_ops->destroy_device(dev);
--
jerome
prev parent reply other threads:[~2015-10-16 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 9:08 [dpdk-dev] [PATCH 0/3] vhost: Fix virtio-net on VHOST_USER_RESET_OWNER Jerome Jutteau
2015-10-16 9:08 ` [dpdk-dev] [PATCH 1/3] vhost: avoid device identifier to be reset to 0 in reset_owner Jerome Jutteau
2015-10-16 9:08 ` [dpdk-dev] [PATCH 2/3] vhost: check that a device exists during reset_owner Jerome Jutteau
2015-10-19 4:35 ` Yuanhan Liu
2015-10-19 9:42 ` Jérôme Jutteau
2015-10-16 9:08 ` Jerome Jutteau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444986530-20893-4-git-send-email-jerome.jutteau@outscale.com \
--to=jerome.jutteau@outscale.com \
--cc=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).