DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <shemming@brocade.com>
Subject: [dpdk-dev] [PATCH 9/9] rte_ether: mark deprecated statistics with attribute
Date: Fri, 16 Oct 2015 17:14:42 -0700	[thread overview]
Message-ID: <1445040882-31006-10-git-send-email-stephen@networkplumber.org> (raw)
In-Reply-To: <1445040882-31006-1-git-send-email-stephen@networkplumber.org>

From: Stephen Hemminger <shemming@brocade.com>

Use deprecated attribute to highlight any use of fields that
are marked as going away in the rte_ether device statistics.

Signed-off-by: Stephen Hemminger <shemming@brocade.com>
---
 lib/librte_eal/common/include/rte_common.h |  3 +++
 lib/librte_ether/rte_ethdev.h              | 22 +++++++++++-----------
 2 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h
index 3121314..f8ca6f3 100644
--- a/lib/librte_eal/common/include/rte_common.h
+++ b/lib/librte_eal/common/include/rte_common.h
@@ -69,6 +69,9 @@ typedef uint32_t unaligned_uint32_t;
 typedef uint16_t unaligned_uint16_t;
 #endif
 
+/******* Macro to mark functions and fields scheduled for removal *****/
+#define __rte_deprecated	__attribute__((__deprecated__))
+
 /*********** Macros to eliminate unused variable warnings ********/
 
 /**
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 8a8c82b..4919963 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -194,28 +194,28 @@ struct rte_eth_stats {
 	uint64_t opackets;  /**< Total number of successfully transmitted packets.*/
 	uint64_t ibytes;    /**< Total number of successfully received bytes. */
 	uint64_t obytes;    /**< Total number of successfully transmitted bytes. */
-	uint64_t imissed;
-	/**< Deprecated; Total of RX missed packets (e.g full FIFO). */
-	uint64_t ibadcrc;
+	uint64_t imissed __rte_deprecated;
+	/**< Deprecated: Total of RX missed packets (e.g full FIFO). */
+	uint64_t ibadcrc __rte_deprecated;
 	/**< Deprecated; Total of RX packets with CRC error. */
-	uint64_t ibadlen;
+	uint64_t ibadlen __rte_deprecated;
 	/**< Deprecated; Total of RX packets with bad length. */
 	uint64_t ierrors;   /**< Total number of erroneous received packets. */
 	uint64_t oerrors;   /**< Total number of failed transmitted packets. */
-	uint64_t imcasts;
+	uint64_t imcasts __rte_deprecated;
 	/**< Deprecated; Total number of multicast received packets. */
 	uint64_t rx_nombuf; /**< Total number of RX mbuf allocation failures. */
-	uint64_t fdirmatch;
+	uint64_t fdirmatch __rte_deprecated;
 	/**< Deprecated; Total number of RX packets matching a filter. */
-	uint64_t fdirmiss;
+	uint64_t fdirmiss __rte_deprecated;
 	/**< Deprecated; Total number of RX packets not matching any filter. */
-	uint64_t tx_pause_xon;
+	uint64_t tx_pause_xon __rte_deprecated;
 	 /**< Deprecated; Total nb. of XON pause frame sent. */
-	uint64_t rx_pause_xon;
+	uint64_t rx_pause_xon  __rte_deprecated;
 	/**< Deprecated; Total nb. of XON pause frame received. */
-	uint64_t tx_pause_xoff;
+	uint64_t tx_pause_xoff __rte_deprecated;
 	/**< Deprecated; Total nb. of XOFF pause frame sent. */
-	uint64_t rx_pause_xoff;
+	uint64_t rx_pause_xoff __rte_deprecated;
 	/**< Deprecated; Total nb. of XOFF pause frame received. */
 	uint64_t q_ipackets[RTE_ETHDEV_QUEUE_STAT_CNTRS];
 	/**< Total number of queue RX packets. */
-- 
2.1.4

  parent reply	other threads:[~2015-10-17  0:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-17  0:14 [dpdk-dev] [PATCH 0/9] deprecate fields in rte_ethdev Stephen Hemminger
2015-10-17  0:14 ` [dpdk-dev] [PATCH 1/9] vmxnet3: drop deprecated statistics Stephen Hemminger
2015-10-17  0:14 ` [dpdk-dev] [PATCH 2/9] ixgbe: drop statistics marked for deprecation Stephen Hemminger
2015-10-17  0:14 ` [dpdk-dev] [PATCH 3/9] bond: don't sum deprecated statistics Stephen Hemminger
2015-10-17  0:14 ` [dpdk-dev] [PATCH 4/9] cxgbe: don't report " Stephen Hemminger
2015-10-17  0:14 ` [dpdk-dev] [PATCH 5/9] i40e: " Stephen Hemminger
2015-10-17  0:14 ` [dpdk-dev] [PATCH 6/9] enic: don't fill in " Stephen Hemminger
2015-10-17  0:14 ` [dpdk-dev] [PATCH 7/9] e1000: don't report " Stephen Hemminger
2015-10-17  0:14 ` [dpdk-dev] [PATCH 8/9] test-pmd: don't check deprecated ethernet statistics Stephen Hemminger
2015-10-17  0:14 ` Stephen Hemminger [this message]
2015-11-03  0:02 ` [dpdk-dev] [PATCH 0/9] deprecate fields in rte_ethdev Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445040882-31006-10-git-send-email-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=shemming@brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).