DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <shemming@brocade.com>
Subject: [dpdk-dev] [PATCH 7/9] e1000: don't report deprecated statistics
Date: Fri, 16 Oct 2015 17:14:40 -0700	[thread overview]
Message-ID: <1445040882-31006-8-git-send-email-stephen@networkplumber.org> (raw)
In-Reply-To: <1445040882-31006-1-git-send-email-stephen@networkplumber.org>

From: Stephen Hemminger <shemming@brocade.com>

These fields are marked deprecated don't use them.

Signed-off-by: Stephen Hemminger <shemming@brocade.com>
---
 drivers/net/e1000/em_ethdev.c  | 15 +++------------
 drivers/net/e1000/igb_ethdev.c | 15 ++-------------
 2 files changed, 5 insertions(+), 25 deletions(-)

diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
index 912f5dd..9e1f105 100644
--- a/drivers/net/e1000/em_ethdev.c
+++ b/drivers/net/e1000/em_ethdev.c
@@ -846,12 +846,9 @@ eth_em_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats)
 		return;
 
 	/* Rx Errors */
-	rte_stats->ibadcrc = stats->crcerrs;
-	rte_stats->ibadlen = stats->rlec + stats->ruc + stats->roc;
-	rte_stats->imissed = stats->mpc;
-	rte_stats->ierrors = rte_stats->ibadcrc +
-	                     rte_stats->ibadlen +
-	                     rte_stats->imissed +
+	rte_stats->ierrors = stats->crcerrs +
+	                     stats->rlec + stats->ruc + stats->roc +
+	                     stats->mpc +
 	                     stats->rxerrc + stats->algnerrc + stats->cexterr;
 
 	/* Tx Errors */
@@ -861,12 +858,6 @@ eth_em_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats)
 	rte_stats->opackets = stats->gptc;
 	rte_stats->ibytes   = stats->gorc;
 	rte_stats->obytes   = stats->gotc;
-
-	/* XON/XOFF pause frames stats registers */
-	rte_stats->tx_pause_xon  = stats->xontxc;
-	rte_stats->rx_pause_xon  = stats->xonrxc;
-	rte_stats->tx_pause_xoff = stats->xofftxc;
-	rte_stats->rx_pause_xoff = stats->xoffrxc;
 }
 
 static void
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 848ef6e..749a41c 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -1370,23 +1370,13 @@ eth_igb_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats)
 		return;
 
 	/* Rx Errors */
-	rte_stats->ibadcrc = stats->crcerrs;
-	rte_stats->ibadlen = stats->rlec + stats->ruc + stats->roc;
-	rte_stats->imissed = stats->mpc;
-	rte_stats->ierrors = rte_stats->ibadcrc +
-	                     rte_stats->ibadlen +
-	                     rte_stats->imissed +
+	rte_stats->ierrors = stats->crcerrs + stats->rlec +
+			     stats->ruc + stats->roc + stats->mpc +
 	                     stats->rxerrc + stats->algnerrc + stats->cexterr;
 
 	/* Tx Errors */
 	rte_stats->oerrors = stats->ecol + stats->latecol;
 
-	/* XON/XOFF pause frames */
-	rte_stats->tx_pause_xon  = stats->xontxc;
-	rte_stats->rx_pause_xon  = stats->xonrxc;
-	rte_stats->tx_pause_xoff = stats->xofftxc;
-	rte_stats->rx_pause_xoff = stats->xoffrxc;
-
 	rte_stats->ipackets = stats->gprc;
 	rte_stats->opackets = stats->gptc;
 	rte_stats->ibytes   = stats->gorc;
@@ -1456,7 +1446,6 @@ eth_igbvf_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats)
 	rte_stats->ibytes = hw_stats->gorc;
 	rte_stats->opackets = hw_stats->gptc;
 	rte_stats->obytes = hw_stats->gotc;
-	rte_stats->imcasts = hw_stats->mprc;
 	rte_stats->ilbpackets = hw_stats->gprlbc;
 	rte_stats->ilbbytes = hw_stats->gorlbc;
 	rte_stats->olbpackets = hw_stats->gptlbc;
-- 
2.1.4

  parent reply	other threads:[~2015-10-17  0:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-17  0:14 [dpdk-dev] [PATCH 0/9] deprecate fields in rte_ethdev Stephen Hemminger
2015-10-17  0:14 ` [dpdk-dev] [PATCH 1/9] vmxnet3: drop deprecated statistics Stephen Hemminger
2015-10-17  0:14 ` [dpdk-dev] [PATCH 2/9] ixgbe: drop statistics marked for deprecation Stephen Hemminger
2015-10-17  0:14 ` [dpdk-dev] [PATCH 3/9] bond: don't sum deprecated statistics Stephen Hemminger
2015-10-17  0:14 ` [dpdk-dev] [PATCH 4/9] cxgbe: don't report " Stephen Hemminger
2015-10-17  0:14 ` [dpdk-dev] [PATCH 5/9] i40e: " Stephen Hemminger
2015-10-17  0:14 ` [dpdk-dev] [PATCH 6/9] enic: don't fill in " Stephen Hemminger
2015-10-17  0:14 ` Stephen Hemminger [this message]
2015-10-17  0:14 ` [dpdk-dev] [PATCH 8/9] test-pmd: don't check deprecated ethernet statistics Stephen Hemminger
2015-10-17  0:14 ` [dpdk-dev] [PATCH 9/9] rte_ether: mark deprecated statistics with attribute Stephen Hemminger
2015-11-03  0:02 ` [dpdk-dev] [PATCH 0/9] deprecate fields in rte_ethdev Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445040882-31006-8-git-send-email-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=shemming@brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).