DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerome Jutteau <jerome.jutteau@outscale.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 0/4] vhost: Fix virtio-net on VHOST_USER_RESET_OWNER
Date: Mon, 19 Oct 2015 11:44:25 +0200	[thread overview]
Message-ID: <1445247869-713-1-git-send-email-jerome.jutteau@outscale.com> (raw)

Hi,

I have a bug when Qemu with two vhost interfaces gently stops (SIGINT).
When stopping, it sends two RESET_OWNER for each interface:
- Before stopping, we have two interfaces identifers: 0 and 1.
- The first reset_owner call resets device 1 (and this id device_fh) to zero,
  the device list now contains two devices with id 0.
- The second call don't find device 1 and segfault as reset_owner don't
  check if the device has been found or not.
- Later, user_get_vring_base can also segfault for the same reason.

This series of patches propose to fix the way reset_owner alter a device and
add more checks when searching for a device.

In this v2, we use get_device instead of get_config_ll_entry to get an error
message when a device is not found.

Jerome Jutteau (4):
  vhost: avoid device identifier to be reset to 0 in reset_owner
  vhost: check that a device exists during reset_owner
  vhost: protect user_get_vring_base from unknown devices
  vhost: change method to get device in reset_owner

 lib/librte_vhost/vhost_user/virtio-net-user.c |  2 ++
 lib/librte_vhost/virtio-net.c                 | 14 +++++++++-----
 2 files changed, 11 insertions(+), 5 deletions(-)

-- 
jerome

             reply	other threads:[~2015-10-19  9:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19  9:44 Jerome Jutteau [this message]
2015-10-19  9:44 ` [dpdk-dev] [PATCH v2 1/4] vhost: avoid device identifier to be reset to 0 in reset_owner Jerome Jutteau
2015-10-19  9:44 ` [dpdk-dev] [PATCH v2 2/4] vhost: check that a device exists during reset_owner Jerome Jutteau
2015-10-19  9:44 ` [dpdk-dev] [PATCH v2 3/4] vhost: protect user_get_vring_base from unknown devices Jerome Jutteau
2015-10-19  9:44 ` [dpdk-dev] [PATCH v2 4/4] vhost: change method to get device in reset_owner Jerome Jutteau
2015-10-20  8:25 ` [dpdk-dev] [PATCH v2 0/4] vhost: Fix virtio-net on VHOST_USER_RESET_OWNER Yuanhan Liu
2015-10-21 10:26   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445247869-713-1-git-send-email-jerome.jutteau@outscale.com \
    --to=jerome.jutteau@outscale.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).