DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2 1/1] ethdev: distinguish between drop and error stats
@ 2015-10-19 12:20 Maryam Tahhan
  2015-11-02 23:46 ` Thomas Monjalon
  0 siblings, 1 reply; 5+ messages in thread
From: Maryam Tahhan @ 2015-10-19 12:20 UTC (permalink / raw)
  To: dev

Make a distniction between dropped packets and error statistics to allow
a higher level fault management entity to interact with DPDK and take
appropriate measures when errors are detected. It will also provide
valuable information for any applications that collects/extracts DPDK
stats, such applications include Open vSwitch.
After this patch the distinction is:
ierrors = Total number of packets dropped by hardware (malformed
packets, ...) Where the # of drops can ONLY be <=  the packets received
(without overlap between registers).
ipkterrors = Total number of erroneous received packets. Where the #
of errors can be >= the packets received (without overlap between
registers), this is because there may be multiple errors associated with
a packet.

v2:
 - Added detailed descriptions for ierrors and ipkterrors.

Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
---
 lib/librte_ether/rte_ethdev.h | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 8a8c82b..e27ba31 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -200,8 +200,18 @@ struct rte_eth_stats {
 	/**< Deprecated; Total of RX packets with CRC error. */
 	uint64_t ibadlen;
 	/**< Deprecated; Total of RX packets with bad length. */
-	uint64_t ierrors;   /**< Total number of erroneous received packets. */
+	uint64_t ierrors;
+	/**< Total number of packets dropped by hardware (malformed packets...)
+	 * Where the # of drops can ONLY be <=  the packets received (without
+	 * overlap between registers).
+	 */
 	uint64_t oerrors;   /**< Total number of failed transmitted packets. */
+	uint64_t ipkterrors;
+	/**< Total number of erroneous received packets. Where the number of
+	 * errors can be >= the packets received (without overlap between
+	 * registers), this is because there may be multiple errors associated with
+	 * a packet.
+	 */
 	uint64_t imcasts;
 	/**< Deprecated; Total number of multicast received packets. */
 	uint64_t rx_nombuf; /**< Total number of RX mbuf allocation failures. */
-- 
2.4.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-11-03 14:56 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-19 12:20 [dpdk-dev] [PATCH v2 1/1] ethdev: distinguish between drop and error stats Maryam Tahhan
2015-11-02 23:46 ` Thomas Monjalon
2015-11-03 13:14   ` Tahhan, Maryam
2015-11-03 13:55     ` Thomas Monjalon
2015-11-03 14:56       ` Tahhan, Maryam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).