* [dpdk-dev] [PATCH v2] ixgbe: remove rx jabber from ierrors [not found] <20151014163553.GB7420@bricha3-MOBL3> @ 2015-10-14 17:12 ` Harry van Haaren 2015-10-20 1:13 ` Lu, Wenzhuo 2015-10-20 9:23 ` [dpdk-dev] [PATCH v3] " Harry van Haaren 0 siblings, 2 replies; 8+ messages in thread From: Harry van Haaren @ 2015-10-14 17:12 UTC (permalink / raw) To: dev Remove receive jabber count from ierrors count as the registers overlap, previously causing some packets to be counted twice. Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> --- v2: Fixed typo drivers/net/ixgbe/ixgbe_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index ec2918c..6e20e06 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -2206,7 +2206,6 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) hw_stats->mlfc + hw_stats->mrfc + hw_stats->rfc + - hw_stats->rjc + hw_stats->fccrc + hw_stats->fclast; -- 1.9.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH v2] ixgbe: remove rx jabber from ierrors 2015-10-14 17:12 ` [dpdk-dev] [PATCH v2] ixgbe: remove rx jabber from ierrors Harry van Haaren @ 2015-10-20 1:13 ` Lu, Wenzhuo 2015-10-20 8:30 ` Van Haaren, Harry 2015-10-20 9:23 ` [dpdk-dev] [PATCH v3] " Harry van Haaren 1 sibling, 1 reply; 8+ messages in thread From: Lu, Wenzhuo @ 2015-10-20 1:13 UTC (permalink / raw) To: Van Haaren, Harry, dev Hi Harry, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren > Sent: Thursday, October 15, 2015 1:12 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] ixgbe: remove rx jabber from ierrors > > Remove receive jabber count from ierrors count as the registers overlap, > previously causing some packets to be counted twice. Would you like to let us know which register RJC overlaps into? Thanks. > > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> > --- > v2: Fixed typo > > drivers/net/ixgbe/ixgbe_ethdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index ec2918c..6e20e06 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2206,7 +2206,6 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, > struct rte_eth_stats *stats) > hw_stats->mlfc + > hw_stats->mrfc + > hw_stats->rfc + > - hw_stats->rjc + > hw_stats->fccrc + > hw_stats->fclast; > > -- > 1.9.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH v2] ixgbe: remove rx jabber from ierrors 2015-10-20 1:13 ` Lu, Wenzhuo @ 2015-10-20 8:30 ` Van Haaren, Harry 2015-10-20 8:49 ` Lu, Wenzhuo 0 siblings, 1 reply; 8+ messages in thread From: Van Haaren, Harry @ 2015-10-20 8:30 UTC (permalink / raw) To: Lu, Wenzhuo, dev Hi Wenzhuo, > From: Lu, Wenzhuo > > Remove receive jabber count from ierrors count as the registers overlap, > > previously causing some packets to be counted twice. > > Would you like to let us know which register RJC overlaps into? Thanks. It seems that the RJC register overlaps with CRC errors. Thanks for looking at this patch, -Harry ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH v2] ixgbe: remove rx jabber from ierrors 2015-10-20 8:30 ` Van Haaren, Harry @ 2015-10-20 8:49 ` Lu, Wenzhuo 0 siblings, 0 replies; 8+ messages in thread From: Lu, Wenzhuo @ 2015-10-20 8:49 UTC (permalink / raw) To: Van Haaren, Harry, dev Hi Harry, > -----Original Message----- > From: Van Haaren, Harry > Sent: Tuesday, October 20, 2015 4:30 PM > To: Lu, Wenzhuo; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] ixgbe: remove rx jabber from ierrors > > Hi Wenzhuo, > > > From: Lu, Wenzhuo > > > Remove receive jabber count from ierrors count as the registers > > > overlap, previously causing some packets to be counted twice. > > > > Would you like to let us know which register RJC overlaps into? Thanks. > > It seems that the RJC register overlaps with CRC errors. > > Thanks for looking at this patch, -Harry Yes, you're right. Would you like to add this info to the comments? It'll help to make things clear. Thanks. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH v3] ixgbe: remove rx jabber from ierrors 2015-10-14 17:12 ` [dpdk-dev] [PATCH v2] ixgbe: remove rx jabber from ierrors Harry van Haaren 2015-10-20 1:13 ` Lu, Wenzhuo @ 2015-10-20 9:23 ` Harry van Haaren 2015-10-20 9:38 ` Tahhan, Maryam 2015-10-21 0:54 ` Lu, Wenzhuo 1 sibling, 2 replies; 8+ messages in thread From: Harry van Haaren @ 2015-10-20 9:23 UTC (permalink / raw) To: dev Remove receive jabber count (rjc) from ierrors count as the register overlaps with the CRC error register, previously causing some packets to be counted twice. Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> --- v3: Add details about register overlap v2: Fix typo drivers/net/ixgbe/ixgbe_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index ec2918c..6e20e06 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -2206,7 +2206,6 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) hw_stats->mlfc + hw_stats->mrfc + hw_stats->rfc + - hw_stats->rjc + hw_stats->fccrc + hw_stats->fclast; -- 1.9.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH v3] ixgbe: remove rx jabber from ierrors 2015-10-20 9:23 ` [dpdk-dev] [PATCH v3] " Harry van Haaren @ 2015-10-20 9:38 ` Tahhan, Maryam 2015-10-21 0:54 ` Lu, Wenzhuo 1 sibling, 0 replies; 8+ messages in thread From: Tahhan, Maryam @ 2015-10-20 9:38 UTC (permalink / raw) To: Van Haaren, Harry, dev > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren > Sent: Tuesday, October 20, 2015 10:23 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3] ixgbe: remove rx jabber from ierrors > > Remove receive jabber count (rjc) from ierrors count as the register overlaps > with the CRC error register, previously causing some packets to be counted > twice. > > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> > --- > > v3: Add details about register overlap > v2: Fix typo > > drivers/net/ixgbe/ixgbe_ethdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index ec2918c..6e20e06 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2206,7 +2206,6 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, > struct rte_eth_stats *stats) > hw_stats->mlfc + > hw_stats->mrfc + > hw_stats->rfc + > - hw_stats->rjc + > hw_stats->fccrc + > hw_stats->fclast; > > -- > 1.9.1 Acked-by: Maryam Tahhan <maryam.tahhan@intel.com> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH v3] ixgbe: remove rx jabber from ierrors 2015-10-20 9:23 ` [dpdk-dev] [PATCH v3] " Harry van Haaren 2015-10-20 9:38 ` Tahhan, Maryam @ 2015-10-21 0:54 ` Lu, Wenzhuo 2015-10-28 14:11 ` Thomas Monjalon 1 sibling, 1 reply; 8+ messages in thread From: Lu, Wenzhuo @ 2015-10-21 0:54 UTC (permalink / raw) To: Van Haaren, Harry, dev Hi, > -----Original Message----- > From: Van Haaren, Harry > Sent: Tuesday, October 20, 2015 5:23 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo; Van Haaren, Harry > Subject: [PATCH v3] ixgbe: remove rx jabber from ierrors > > Remove receive jabber count (rjc) from ierrors count as the register overlaps > with the CRC error register, previously causing some packets to be counted > twice. > > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH v3] ixgbe: remove rx jabber from ierrors 2015-10-21 0:54 ` Lu, Wenzhuo @ 2015-10-28 14:11 ` Thomas Monjalon 0 siblings, 0 replies; 8+ messages in thread From: Thomas Monjalon @ 2015-10-28 14:11 UTC (permalink / raw) To: Van Haaren, Harry; +Cc: dev > > Remove receive jabber count (rjc) from ierrors count as the register overlaps > > with the CRC error register, previously causing some packets to be counted > > twice. > > > > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> > Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com> Applied, thanks ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-10-28 14:12 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20151014163553.GB7420@bricha3-MOBL3>
2015-10-14 17:12 ` [dpdk-dev] [PATCH v2] ixgbe: remove rx jabber from ierrors Harry van Haaren
2015-10-20 1:13 ` Lu, Wenzhuo
2015-10-20 8:30 ` Van Haaren, Harry
2015-10-20 8:49 ` Lu, Wenzhuo
2015-10-20 9:23 ` [dpdk-dev] [PATCH v3] " Harry van Haaren
2015-10-20 9:38 ` Tahhan, Maryam
2015-10-21 0:54 ` Lu, Wenzhuo
2015-10-28 14:11 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).