From: Maryam Tahhan <maryam.tahhan@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 1/1] ethdev: remove the imissed deprecation tag
Date: Tue, 20 Oct 2015 11:34:18 +0100 [thread overview]
Message-ID: <1445337258-6101-1-git-send-email-maryam.tahhan@intel.com> (raw)
Remove the deprecation tag and notice for imissed as it is a generic
register that accounts for packets that were dropped by the HW,
because there are no available mbufs (RX queues are full). imissed is
different to ierrors and can help with general debug.
Fixes: 49f386542af4 ("ethdev: remove driver specific stats")
Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
---
v2:
- Clarify why imissed is no longer deprecated.
- Improve definition of imissed in the documentation.
---
doc/guides/rel_notes/deprecation.rst | 2 +-
lib/librte_ether/rte_ethdev.h | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index fa55117..c4babbd 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -14,7 +14,7 @@ Deprecation Notices
All binaries will need to be rebuilt from release 2.2.
* The following fields have been deprecated in rte_eth_stats:
- imissed, ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss,
+ ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss,
tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff
* ABI changes are planned for struct rte_eth_fdir_flow_ext in order to support
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 8a8c82b..d404f85 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -195,7 +195,9 @@ struct rte_eth_stats {
uint64_t ibytes; /**< Total number of successfully received bytes. */
uint64_t obytes; /**< Total number of successfully transmitted bytes. */
uint64_t imissed;
- /**< Deprecated; Total of RX missed packets (e.g full FIFO). */
+ /**< Total of RX missed packets (packets that were dropped by the HW,
+ * because there are no available mbufs i.e. RX queues are full).
+ */
uint64_t ibadcrc;
/**< Deprecated; Total of RX packets with CRC error. */
uint64_t ibadlen;
--
2.4.3
next reply other threads:[~2015-10-20 10:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 10:34 Maryam Tahhan [this message]
2015-11-02 23:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445337258-6101-1-git-send-email-maryam.tahhan@intel.com \
--to=maryam.tahhan@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).