DPDK patches and discussions
 help / color / mirror / Atom feed
From: Xutao Sun <xutao.sun@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3] examples/vmdq: Fix the core dump issue when mem_pool is more than 34
Date: Tue, 27 Oct 2015 16:58:33 +0800	[thread overview]
Message-ID: <1445936313-31782-1-git-send-email-xutao.sun@intel.com> (raw)
In-Reply-To: <1445922658-4955-1-git-send-email-xutao.sun@intel.com>

Macro MAX_QUEUES was defined to 128, only allow 16 vmdq_pools in theory.
When running vmdq_app with more than 34 vmdq_pools, it will cause the
core_dump issue.
Change MAX_QUEUES to 1024 will solve this issue.

Signed-off-by: Xutao Sun <xutao.sun@intel.com>
---
v2:
 - Rectify the NUM_MBUFS_PER_PORT since MAX_QUEUES has been changed

v3:
 - Change the comments above the relevant code.
 
 examples/vmdq/main.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c
index a142d49..178af2f 100644
--- a/examples/vmdq/main.c
+++ b/examples/vmdq/main.c
@@ -69,12 +69,13 @@
 #include <rte_mbuf.h>
 #include <rte_memcpy.h>
 
-#define MAX_QUEUES 128
+#define MAX_QUEUES 1024
 /*
- * For 10 GbE, 128 queues require roughly
- * 128*512 (RX/TX_queue_nb * RX/TX_ring_descriptors_nb) per port.
+ * 1024 queues require to meet the needs of a large number of vmdq_pools.
+ * (RX/TX_queue_nb * RX/TX_ring_descriptors_nb) per port.
  */
-#define NUM_MBUFS_PER_PORT (128*512)
+#define NUM_MBUFS_PER_PORT (MAX_QUEUES * RTE_MAX(RTE_TEST_RX_DESC_DEFAULT, \
+						RTE_TEST_TX_DESC_DEFAULT))
 #define MBUF_CACHE_SIZE 64
 
 #define MAX_PKT_BURST 32
-- 
1.9.3

  parent reply	other threads:[~2015-10-27  8:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13  7:29 [dpdk-dev] [PATCH] " Xutao Sun
2015-10-13  7:59 ` De Lara Guarch, Pablo
2015-10-15  7:54   ` Sun, Xutao
2015-10-27  5:10 ` [dpdk-dev] [PATCH v2] " Xutao Sun
2015-10-27  7:55   ` De Lara Guarch, Pablo
2015-10-27  8:22     ` Sun, Xutao
2015-10-27  8:58   ` Xutao Sun [this message]
2015-10-29  7:53     ` [dpdk-dev] [PATCH v3] " De Lara Guarch, Pablo
2015-12-07  1:46       ` Thomas Monjalon
2015-10-30  5:54   ` [dpdk-dev] [PATCH v2] " Wu, Jingjing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445936313-31782-1-git-send-email-xutao.sun@intel.com \
    --to=xutao.sun@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).