DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bernard Iremonger <bernard.iremonger@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v6 22/28] null: remove pci device
Date: Thu, 29 Oct 2015 18:36:29 +0000	[thread overview]
Message-ID: <1446143795-31841-23-git-send-email-bernard.iremonger@intel.com> (raw)
In-Reply-To: <1446143795-31841-1-git-send-email-bernard.iremonger@intel.com>

remove rte_null_pmd and pci_dev.

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/null/rte_eth_null.c | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index d34b60e..f12f31e 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -379,7 +379,6 @@ eth_dev_null_create(const char *name,
 	const unsigned nb_rx_queues = 1;
 	const unsigned nb_tx_queues = 1;
 	struct rte_eth_dev_data *data = NULL;
-	struct rte_pci_device *pci_dev = NULL;
 	struct pmd_internals *internals = NULL;
 	struct rte_eth_dev *eth_dev = NULL;
 
@@ -396,10 +395,6 @@ eth_dev_null_create(const char *name,
 	if (data == NULL)
 		goto error;
 
-	pci_dev = rte_zmalloc_socket(name, sizeof(*pci_dev), 0, numa_node);
-	if (pci_dev == NULL)
-		goto error;
-
 	internals = rte_zmalloc_socket(name, sizeof(*internals), 0, numa_node);
 	if (internals == NULL)
 		goto error;
@@ -411,8 +406,8 @@ eth_dev_null_create(const char *name,
 
 	/* now put it all together
 	 * - store queue data in internals,
-	 * - store numa_node info in pci_driver
-	 * - point eth_dev_data to internals and pci_driver
+	 * - store numa_node info in ethdev data
+	 * - point eth_dev_data to internals
 	 * - and point eth_dev structure to new eth_dev_data structure
 	 */
 	/* NOTE: we'll replace the data element, of originally allocated eth_dev
@@ -424,8 +419,6 @@ eth_dev_null_create(const char *name,
 	internals->packet_copy = packet_copy;
 	internals->numa_node = numa_node;
 
-	pci_dev->numa_node = numa_node;
-
 	data->dev_private = internals;
 	data->port_id = eth_dev->data->port_id;
 	data->nb_rx_queues = (uint16_t)nb_rx_queues;
@@ -455,7 +448,6 @@ eth_dev_null_create(const char *name,
 
 error:
 	rte_free(data);
-	rte_free(pci_dev);
 	rte_free(internals);
 
 	return -1;
@@ -558,14 +550,13 @@ rte_pmd_null_devuninit(const char *name)
 	RTE_LOG(INFO, PMD, "Closing null ethdev on numa socket %u\n",
 			rte_socket_id());
 
-	/* reserve an ethdev entry */
+	/* find the ethdev entry */
 	eth_dev = rte_eth_dev_allocated(name);
 	if (eth_dev == NULL)
 		return -1;
 
 	rte_free(eth_dev->data->dev_private);
 	rte_free(eth_dev->data);
-	rte_free(eth_dev->pci_dev);
 
 	rte_eth_dev_release_port(eth_dev);
 
-- 
1.9.1

  parent reply	other threads:[~2015-10-29 18:37 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <PATCH v6>
2015-10-29 18:36 ` [dpdk-dev] [PATCH v6 00/28] remove pci driver from vdevs Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 01/28] librte_eal: add RTE_KDRV_NONE for vdevs Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 02/28] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 03/28] librte_ether: add function rte_eth_copy_dev_info Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 04/28] ixgbe: copy pci device info to eth_dev data Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 05/28] e1000: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 06/28] i40e: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 07/28] fm10k: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 08/28] bnx2x: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 09/28] cxgbe: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 10/28] enic: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 11/28] mlx4: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 12/28] virtio: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 13/28] vmxnet3: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 14/28] null: copy " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 15/28] ring: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 16/28] pcap: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 17/28] af_packet: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 18/28] xenvirt: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 19/28] mpipe: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 20/28] bonding: " Bernard Iremonger
2015-10-30 13:12     ` Kulasek, TomaszX
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 21/28] librte_ether: remove branches on pci_dev Bernard Iremonger
2015-10-29 18:36   ` Bernard Iremonger [this message]
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 23/28] ring: remove pci device Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 24/28] pcap: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 25/28] af_packet: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 26/28] xenvirt: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 27/28] mpipe: " Bernard Iremonger
2015-10-29 18:36   ` [dpdk-dev] [PATCH v6 28/28] bonding: " Bernard Iremonger
2015-10-30 13:04     ` Kulasek, TomaszX
2015-10-30 13:32   ` [dpdk-dev] [PATCH v6 00/28] remove pci driver from vdevs David Marchand
2015-10-30 14:00     ` Bruce Richardson
2015-10-30 14:33   ` Qiu, Michael

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446143795-31841-23-git-send-email-bernard.iremonger@intel.com \
    --to=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).