DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@6wind.com>
To: dev@dpdk.org
Cc: Julien Meunier <julien.meunier@6wind.com>
Subject: [dpdk-dev] [PATCH] enic: fix vlan filtering
Date: Fri, 30 Oct 2015 17:13:23 +0100	[thread overview]
Message-ID: <1446221603-10679-1-git-send-email-david.marchand@6wind.com> (raw)

From: Julien Meunier <julien.meunier@6wind.com>

Report an error when something went wrong.

Signed-off-by: Julien Meunier <julien.meunier@6wind.com>
Signed-off-by: David Marchand <david.marchand@6wind.com>
---
 drivers/net/enic/enic_ethdev.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
index e385560..5df9a6c 100644
--- a/drivers/net/enic/enic_ethdev.c
+++ b/drivers/net/enic/enic_ethdev.c
@@ -271,13 +271,14 @@ static int enicpmd_vlan_filter_set(struct rte_eth_dev *eth_dev,
 	uint16_t vlan_id, int on)
 {
 	struct enic *enic = pmd_priv(eth_dev);
+	int err;
 
 	ENICPMD_FUNC_TRACE();
 	if (on)
-		enic_add_vlan(enic, vlan_id);
+		err = enic_add_vlan(enic, vlan_id);
 	else
-		enic_del_vlan(enic, vlan_id);
-	return 0;
+		err = enic_del_vlan(enic, vlan_id);
+	return err;
 }
 
 static void enicpmd_vlan_offload_set(struct rte_eth_dev *eth_dev, int mask)
-- 
1.9.1

             reply	other threads:[~2015-10-30 16:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-30 16:13 David Marchand [this message]
2015-10-31 17:04 ` Sujith Sankar (ssujith)
2015-11-10 16:05   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446221603-10679-1-git-send-email-david.marchand@6wind.com \
    --to=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=julien.meunier@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).