DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jan Viktorin <viktorin@rehivetech.com>
To: david.marchand@6wind.com, David Hunt <david.hunt@intel.com>,
	Thomas Monjalon <thomas.monjalon@6wind.com>,
	Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: Vlastimil Kosar <kosar@rehivetech.com>, dev@dpdk.org
Subject: [dpdk-dev] [PATCH v6 01/15] eal/arm: atomic operations for ARM
Date: Tue,  3 Nov 2015 00:47:14 +0100	[thread overview]
Message-ID: <1446508048-16744-2-git-send-email-viktorin@rehivetech.com> (raw)
In-Reply-To: <1446508048-16744-1-git-send-email-viktorin@rehivetech.com>

From: Vlastimil Kosar <kosar@rehivetech.com>

This patch adds architecture specific atomic operation file
for ARM architecture. The RTE_FORCE_INTRINSICS=y is required.

Signed-off-by: Vlastimil Kosar <kosar@rehivetech.com>
Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
---
v1 -> v2:
* improve rte_wmb()
* use __atomic_* or __sync_*? (may affect the required GCC version)

v4:
* checkpatch complaints about volatile keyword (but seems to be OK to me)
* checkpatch complaints about do { ... } while (0) for single statement
  with asm volatile (but I didn't find a way how to write it without
  the checkpatch complaints)
* checkpatch is now happy with whitespaces

v6:
* separate for 32/64 architectures
* drop the atomic implementation and require to use RTE_FORCE_INTRINSICS
---
 .../common/include/arch/arm/rte_atomic.h           | 38 +++++++++++
 .../common/include/arch/arm/rte_atomic_32.h        | 74 ++++++++++++++++++++++
 2 files changed, 112 insertions(+)
 create mode 100644 lib/librte_eal/common/include/arch/arm/rte_atomic.h
 create mode 100644 lib/librte_eal/common/include/arch/arm/rte_atomic_32.h

diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic.h b/lib/librte_eal/common/include/arch/arm/rte_atomic.h
new file mode 100644
index 0000000..f4f5783
--- /dev/null
+++ b/lib/librte_eal/common/include/arch/arm/rte_atomic.h
@@ -0,0 +1,38 @@
+/*-
+ *   BSD LICENSE
+ *
+ *   Copyright(c) 2015 RehiveTech. All rights reserved.
+ *
+ *   Redistribution and use in source and binary forms, with or without
+ *   modification, are permitted provided that the following conditions
+ *   are met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ *       notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyright
+ *       notice, this list of conditions and the following disclaimer in
+ *       the documentation and/or other materials provided with the
+ *       distribution.
+ *     * Neither the name of RehiveTech nor the names of its
+ *       contributors may be used to endorse or promote products derived
+ *       from this software without specific prior written permission.
+ *
+ *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef _RTE_ATOMIC_ARM_H_
+#define _RTE_ATOMIC_ARM_H_
+
+#include <rte_atomic_32.h>
+
+#endif /* _RTE_ATOMIC_ARM_H_ */
diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_32.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_32.h
new file mode 100644
index 0000000..9ae1e78
--- /dev/null
+++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_32.h
@@ -0,0 +1,74 @@
+/*-
+ *   BSD LICENSE
+ *
+ *   Copyright(c) 2015 RehiveTech. All rights reserved.
+ *
+ *   Redistribution and use in source and binary forms, with or without
+ *   modification, are permitted provided that the following conditions
+ *   are met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ *       notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyright
+ *       notice, this list of conditions and the following disclaimer in
+ *       the documentation and/or other materials provided with the
+ *       distribution.
+ *     * Neither the name of RehiveTech nor the names of its
+ *       contributors may be used to endorse or promote products derived
+ *       from this software without specific prior written permission.
+ *
+ *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef _RTE_ATOMIC_ARM32_H_
+#define _RTE_ATOMIC_ARM32_H_
+
+#ifndef RTE_FORCE_INTRINSICS
+#  error Platform must be built with CONFIG_RTE_FORCE_INTRINSICS
+#endif
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#include "generic/rte_atomic.h"
+
+/**
+ * General memory barrier.
+ *
+ * Guarantees that the LOAD and STORE operations generated before the
+ * barrier occur before the LOAD and STORE operations generated after.
+ */
+#define	rte_mb()  __sync_synchronize()
+
+/**
+ * Write memory barrier.
+ *
+ * Guarantees that the STORE operations generated before the barrier
+ * occur before the STORE operations generated after.
+ */
+#define	rte_wmb() do { asm volatile ("dmb st" : : : "memory"); } while (0)
+
+/**
+ * Read memory barrier.
+ *
+ * Guarantees that the LOAD operations generated before the barrier
+ * occur before the LOAD operations generated after.
+ */
+#define	rte_rmb() __sync_synchronize()
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* _RTE_ATOMIC_ARM32_H_ */
-- 
2.6.2

  reply	other threads:[~2015-11-02 23:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-02 23:47 [dpdk-dev] [PATCH v6 00/15] Support ARMv7 architecture Jan Viktorin
2015-11-02 23:47 ` Jan Viktorin [this message]
2015-11-02 23:47 ` [dpdk-dev] [PATCH v6 02/15] eal/arm: byte order operations for ARM Jan Viktorin
2015-11-02 23:47 ` [dpdk-dev] [PATCH v6 03/15] eal/arm: cpu cycle " Jan Viktorin
2015-11-02 23:47 ` [dpdk-dev] [PATCH v6 04/15] eal/arm: implement rdtsc by PMU or clock_gettime Jan Viktorin
2015-11-02 23:47 ` [dpdk-dev] [PATCH v6 05/15] eal/arm: prefetch operations for ARM Jan Viktorin
2015-11-02 23:47 ` [dpdk-dev] [PATCH v6 06/15] eal/arm: spinlock operations for ARM (without HTM) Jan Viktorin
2015-11-02 23:47 ` [dpdk-dev] [PATCH v6 07/15] eal/arm: vector memcpy for ARM Jan Viktorin
2015-11-02 23:47 ` [dpdk-dev] [PATCH v6 08/15] eal/arm: use vector memcpy only when NEON is enabled Jan Viktorin
2015-11-02 23:47 ` [dpdk-dev] [PATCH v6 09/15] eal/arm: cpu flag checks for ARM Jan Viktorin
2015-11-02 23:47 ` [dpdk-dev] [PATCH v6 10/15] eal/arm: detect arm architecture in cpu flags Jan Viktorin
2015-11-02 23:47 ` [dpdk-dev] [PATCH v6 11/15] eal/arm: rwlock support for ARM Jan Viktorin
2015-11-02 23:47 ` [dpdk-dev] [PATCH v6 12/15] eal/arm: add very incomplete rte_vect Jan Viktorin
2015-11-02 23:47 ` [dpdk-dev] [PATCH v6 13/15] gcc/arm: avoid alignment errors to break build Jan Viktorin
2015-11-02 23:47 ` [dpdk-dev] [PATCH v6 14/15] mk: Introduce ARMv7 architecture Jan Viktorin
2015-11-03 10:16   ` Hunt, David
2015-11-03 10:24     ` Bruce Richardson
2015-11-03 11:18       ` Thomas Monjalon
2015-11-03 10:27     ` Jan Viktorin
2015-11-03 11:08       ` Hunt, David
2015-11-02 23:47 ` [dpdk-dev] [PATCH v6 15/15] maintainers: claim responsibility for ARMv7 Jan Viktorin
2015-11-03  4:49 ` [dpdk-dev] [PATCH v6 00/15] Support ARMv7 architecture Jerin Jacob
2015-11-03 11:33   ` Hunt, David
2015-11-03 12:32     ` Jacob,  Jerin
2015-11-16 21:33 ` David Marchand
2015-11-18 21:45   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446508048-16744-2-git-send-email-viktorin@rehivetech.com \
    --to=viktorin@rehivetech.com \
    --cc=david.hunt@intel.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=kosar@rehivetech.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).