From: Na Na <nana.nn@alibaba-inc.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3 2/2] lib/lpm:fix incorrect reuse of already allocated tbl8
Date: Tue, 3 Nov 2015 10:17:41 +0800 [thread overview]
Message-ID: <1446517061-19261-3-git-send-email-nana.nn@alibaba-inc.com> (raw)
In-Reply-To: <1446517061-19261-1-git-send-email-nana.nn@alibaba-inc.com>
Fixes an initialization issue of 'valid_group' in the delete_depth_small().
When adding an entry to a tbl8, the .valid_group field should always be set,
so that future adds do not accidently find and use this table, thinking it is
currently invalid, i.e. unused, and thereby overwrite existing entries.
Signed-off-by: Na Na <nana.nn@alibaba-inc.com>
---
lib/librte_lpm/rte_lpm.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c
index 57ec2f0..3981452 100644
--- a/lib/librte_lpm/rte_lpm.c
+++ b/lib/librte_lpm/rte_lpm.c
@@ -769,6 +769,7 @@ delete_depth_small(struct rte_lpm *lpm, uint32_t ip_masked,
struct rte_lpm_tbl8_entry new_tbl8_entry = {
.valid = VALID,
+ .valid_group = VALID,
.depth = sub_rule_depth,
.next_hop = lpm->rules_tbl
[sub_rule_index].next_hop,
--
1.7.7.6
next prev parent reply other threads:[~2015-11-03 2:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 2:17 [dpdk-dev] [PATCH v3 0/2] Fix two issues in lpm Na Na
2015-11-03 2:17 ` [dpdk-dev] [PATCH v3 1/2] lib/lpm:fix an issue of condition check in delete_depth_small() Na Na
2015-11-03 2:17 ` Na Na [this message]
2015-11-03 10:26 ` [dpdk-dev] [PATCH v3 0/2] Fix two issues in lpm Bruce Richardson
2015-11-04 0:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446517061-19261-3-git-send-email-nana.nn@alibaba-inc.com \
--to=nana.nn@alibaba-inc.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).